Show seconds in trace start time on the trace page #430
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Joe Farro <[email protected]>
yurishkuro
approved these changes
Aug 4, 2019
| renderer: (trace: Trace) => formatDatetime(trace.startTime), | ||
| renderer: (trace: Trace) => { | ||
| const dateStr = formatDatetime(trace.startTime); | ||
| const match = dateStr.match(/^(.+)(:\d\d\.\d+)$/); |
There was a problem hiding this comment.
I would only lower the contrast for sub-seconds, not for seconds
| <span className="TracePageHeader--overviewItem--valueDetail">{match[2]}</span> | ||
| </span> | ||
| ) : ( | ||
| dateStr |
There was a problem hiding this comment.
should this also use <span> for consistency?
There was a problem hiding this comment.
No, it's better to leave it off if it's not serving a purpose.
Codecov Report
@@ Coverage Diff @@
## master #430 +/- ##
==========================================
+ Coverage 91.67% 91.67% +<.01%
==========================================
Files 176 176
Lines 4010 4012 +2
Branches 928 957 +29
==========================================
+ Hits 3676 3678 +2
+ Misses 296 292 -4
- Partials 38 42 +4
Continue to review full report at Codecov.
|
vvvprabhakar
pushed a commit
to vvvprabhakar/jaeger-ui
that referenced
this pull request
Jul 5, 2021
Show seconds in trace start time on the trace page Signed-off-by: vvvprabhakar <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Trace start time, on the trace page, is not granularity enough.
Short description of the changes
Show the seconds and sub-seconds of the trace start time in the trace page header.
The seconds and sub-seconds are presented with reduced contrast:
The seconds and sub-seconds are shown at full contrast when the datetime value is hovered: