Ddg graph node #405
Merged
Ddg graph node #405
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Joe Farro <[email protected]>
Signed-off-by: Joe Farro <[email protected]>
Signed-off-by: Joe Farro <[email protected]>
Signed-off-by: Joe Farro <[email protected]>
Signed-off-by: Joe Farro <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #405 +/- ##
==========================================
+ Coverage 89.79% 90.45% +0.65%
==========================================
Files 170 169 -1
Lines 3842 3824 -18
Branches 869 879 +10
==========================================
+ Hits 3450 3459 +9
+ Misses 356 329 -27
Partials 36 36
Continue to review full report at Codecov.
|
Signed-off-by: Joe Farro <[email protected]>
everett980
requested changes
Jul 8, 2019
packages/jaeger-ui/src/components/DeepDependencyGraph/getNodeLabel/index.tsx
Outdated
Show resolved
Hide resolved
packages/jaeger-ui/src/components/DeepDependencyGraph/getNodeLabel/index.test.js
Outdated
Show resolved
Hide resolved
|
|
||
| import './DdgNode.css'; | ||
|
|
||
| type TProps = { |
There was a problem hiding this comment.
would it make sense for this to be type TProps = TDdgVertex & { focalNodeUrl..., viewModifierStuff }?
There was a problem hiding this comment.
The props don't quite line up:
vertexKeyvskey(which can't be namedkeyas a prop)labelis not present
Signed-off-by: Joe Farro <[email protected]>
|
@everett980 This is ready for another review. Thanks. |
vvvprabhakar
pushed a commit
to vvvprabhakar/jaeger-ui
that referenced
this pull request
Jul 5, 2021
Ddg graph node Signed-off-by: vvvprabhakar <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add graph node rendering for the DDG graph.