Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fetch ddg action and reducer #398
Fetch ddg action and reducer #398
Changes from 11 commits
4e990da
a8e0fe9
ec450e2
4113737
d027b61
1789da6
93f2d2a
a4be7e7
50cad45
0cbe260
f419baf
c46e04c
7cbd2d7
d2e4aa1
2f9462d
3d1ac6b
d532c5d
be29f79
18d3992
5765a0b
f1a49ce
ccde31e
b3cc5f1
b5aaae1
f8f3250
4cfdac1
a61c55f
877138a
0c329f8
7916ff4
8e43092
2d379f9
125cabb
740b0d5
af09c81
c876011
fc98987
a6cab98
ef15710
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think these can be driven by an array of params?
Seems like the same with the promise tests.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
that's true for most, but not
@JAEGER_API/FETCH_MULTIPLE_TRACES
which calls an action with one name and an API fn with another. I know that's not hard to handle (optional extra key on tests), but perhaps best to leavejaeger-api.test
andapi/jaeger.test
clean up for its own targeted PR?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The reason I mentioned it is because you re-wrote the tests in this PR.