-
Notifications
You must be signed in to change notification settings - Fork 513
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Validate when tags and/or references fields are arrays. #382
Validate when tags and/or references fields are arrays. #382
Conversation
Codecov Report
@@ Coverage Diff @@
## master #382 +/- ##
==========================================
+ Coverage 89.01% 89.07% +0.06%
==========================================
Files 162 162
Lines 3658 3660 +2
Branches 831 833 +2
==========================================
+ Hits 3256 3260 +4
+ Misses 366 364 -2
Partials 36 36
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for another PR!
Rather than have checks for incomplete data, this function could sanitize incomplete data so that all parts of the app can rely on the expected structure of Span
s.
bf1bff3
to
22db0d0
Compare
I did the property changes, I think this is ready for another review. Sorry for the delay. |
22db0d0
to
0ad29df
Compare
Signed-off-by: Ruben Vargas <[email protected]>
0ad29df
to
2bccab4
Compare
LGTM, thanks @rubenvp8510 ! |
…eferences Validate when tags and/or references fields are arrays. Signed-off-by: vvvprabhakar <[email protected]>
Signed-off-by: Ruben Vargas [email protected]
Which problem is this PR solving?
Short description of the changes