Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert from Flow to Typescript for Jaeger-UI #359

Merged
merged 59 commits into from
Mar 26, 2019
Merged

Convert from Flow to Typescript for Jaeger-UI #359

merged 59 commits into from
Mar 26, 2019

Conversation

everett980
Copy link
Collaborator

@everett980 everett980 commented Mar 25, 2019 •
edited by tiffon
Loading

Which problem is this PR solving?

  • Typescript has proven to be superior than Flow, so this PR converts from Flow to Typescript.

Short description of the changes

  • Convert all files with @flow, as well as some of the simple non-flow files.
  • Add script to trace typescript coverage.

Fixes #306.

everett980 and others added 30 commits March 11, 2019 16:56
@everett980
Complie first typescript file successfully
9cc67f0 
Signed-off-by: Everett Ross <[email protected]>
@everett980
Update eslint typescript parser
654375a 
Signed-off-by: Everett Ross <[email protected]>
@everett980
Merge branch 'jaegertracingmaster' into ui-to-ts
10d7d17
@everett980
Convert and consume first types/ file
f4fab60 
Signed-off-by: Everett Ross <[email protected]>
@everett980
Finish types/ and common/, WIP tests due to default values
856d60d 
Signed-off-by: Everett Ross <[email protected]>
@everett980
Fix tests
ec6068b 
Signed-off-by: Everett Ross <[email protected]>
@tiffon
Remove "unpm.uberinternal.com" from yarn.lock
7394aa5 
Signed-off-by: Joe Farro <[email protected]>
@tiffon
Remove prop-type error message
6358d0c 
Signed-off-by: Joe Farro <[email protected]>
@tiffon
Rename all .ts TypeScript files to .tsx
e51fb5a 
Signed-off-by: Joe Farro <[email protected]>
@tiffon
Hone TypeScript linting and build config
611391e 
- Minor tweaks to project root .eslintrc.js

- Changed TypeScript linting to use project references, which lets
  packages have their own typings declarations. This required a second
  tsconfig in jaeger-ui (tsconfig.lint.json) because project references
  and create-react-app require conflicting values for isolatedModules.
  https://www.typescriptlang.org/docs/handbook/project-references.html

- Used extends in jaeger-ui tsconfig files so they are consistent with
  the root tsconfig

- Added process and global to jaeger-ui typings/custom.d.ts so
  @types/node can be removed

- Remove @types/node and @types/jsdom

- Pin parse5@^4.0.0 (via cheerio) to remove its @types/node dependency

- Added TNil to shorten `null | undefined`; a bit on the fence about it

Signed-off-by: Joe Farro <[email protected]>
@tiffon
Convert a few flow files (leaves) to .tsx
3df3d8a 
Remove no-longer-necessary eslint-disable no-unused-vars

Signed-off-by: Joe Farro <[email protected]>
@tiffon
Enable ESLint caching, run npm scripts in parallel
1363788 
Signed-off-by: Joe Farro <[email protected]>
@tiffon
Misc typings cleanup
e8f707b 
Signed-off-by: Joe Farro <[email protected]>
@tiffon
16% - Script to track ts conv progress
2e313c3 
Signed-off-by: Joe Farro <[email protected]>
@tiffon
Conv ListView/Positions to tsx
62d2603 
Signed-off-by: Joe Farro <[email protected]>
@tiffon
Remove @flow from tsx files
c0f81a6 
Signed-off-by: Joe Farro <[email protected]>
@everett980
23.69% - Convert SearchResults, some search utils, and TopNav
f9b2461 
Signed-off-by: Everett Ross <[email protected]>
@tiffon
Conv to tsx
1825599 
Signed-off-by: Joe Farro <[email protected]>
@everett980
31.59% - Convert some tracking utils, remove TNullable
8d5ad47 
Signed-off-by: Everett Ross <[email protected]>
@everett980
35.41% - Convert TraceDiffHeader/
9ee3f7c 
Signed-off-by: Everett Ross <[email protected]>
@tiffon
Conv trace-dag model
2584214 
Signed-off-by: Joe Farro <[email protected]>
@tiffon
Merge branch 'master' into ui-to-ts
74f8f6d 
Signed-off-by: Joe Farro <[email protected]>
@tiffon
Conv to tsx, more flexible type defs for plexus
78052ac 
Signed-off-by: Joe Farro <[email protected]>
@tiffon
Conv trace diff graph, improve plexus type defs
e3a2330 
Signed-off-by: Joe Farro <[email protected]>
@tiffon
Conv TraceDiff
f89eb1f 
Signed-off-by: Joe Farro <[email protected]>
@everett980
45.97% - Convert OpNode and calculateTraceDagEv
0391688 
Signed-off-by: Everett Ross <[email protected]>
@everett980
47.48% - Convert some SpanGraph files
d50ddec 
Signed-off-by: Everett Ross <[email protected]>
@everett980
48.73 - Conv some TraceTimelineViewer utils
0111779 
Signed-off-by: Everett Ross <[email protected]>
@everett980
Merge branch 'develop' into ui-to-ts
c04e854
@tiffon
Conv DraggableManager to tsx
c459a8f 
Signed-off-by: Joe Farro <[email protected]>
everett980 and others added 16 commits March 19, 2019 18:30
@everett980
69.21% - Convert SpanBar and its dependencies
7101bb1 
Signed-off-by: Everett Ross <[email protected]>
@everett980
77.49% - Convert SpanBar and its dependencies, and ListView
c13558d 
Signed-off-by: Everett Ross <[email protected]>
@everett980
84.69% - Convert VirtualizedTraceView & link-patterns, fix TraceDiff
1ef4222 
Signed-off-by: Everett Ross <[email protected]>
@everett980
86.74% - Convert TraceGraph.tsx
c601be2 
Signed-off-by: Everett Ross <[email protected]>
@tiffon
85.3% - Conv keyboard-shortucts to tsx
b518ec8 
Signed-off-by: Joe Farro <[email protected]>
@tiffon
88% - Conv TraceTimelineViewer/index to tsx
6fbb8ad 
Signed-off-by: Joe Farro <[email protected]>
@tiffon
Conv scroll-page to tsx
e00bac6 
Signed-off-by: Joe Farro <[email protected]>
@tiffon
Conv ArchiveNotifier to tsx
e628091 
Signed-off-by: Joe Farro <[email protected]>
@tiffon
Conv readJsonFile and related to tsx
b3fb7c3 
Signed-off-by: Joe Farro <[email protected]>
@tiffon
91.5% - Conv a few files, hone type defs in a few
753af4b 
Signed-off-by: Joe Farro <[email protected]>
@tiffon
Conv middlewares/track to tsx
afe96a3 
Signed-off-by: Joe Farro <[email protected]>
@tiffon
Conv ArchiveNotifier/duck to tsx
4f6c64c 
Signed-off-by: Joe Farro <[email protected]>
@tiffon
95.6% - Conv TracePage to tsx
b7ea49e 
Signed-off-by: Joe Farro <[email protected]>
@tiffon
100% - Conv all the things to tsx
96ca354 
Signed-off-by: Joe Farro <[email protected]>
@tiffon
78.25 - Show conversion progress for JS to TS
3cb89d1 
Signed-off-by: Joe Farro <[email protected]>
@everett980
Clean up some Typescript TODOs
cf28859 
Signed-off-by: Everett Ross <[email protected]>
@ghost ghost assigned everett980 Mar 25, 2019
@ghost ghost added the review label Mar 25, 2019
@codecov
Copy link

codecov bot commented Mar 25, 2019 •
edited
Loading

Codecov Report

Merging #359 into master will decrease coverage by 2.69%.
The diff coverage is 92.08%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #359     +/-   ##
=========================================
- Coverage   90.87%   88.17%   -2.7%     
=========================================
  Files         151      157      +6     
  Lines        3275     3493    +218     
  Branches      662      798    +136     
=========================================
+ Hits         2976     3080    +104     
- Misses        245      376    +131     
+ Partials       54       37     -17
Impacted Files Coverage Δ
packages/jaeger-ui/src/utils/span-ancestor-ids.tsx 100% <ø> (ø)
...racePage/TracePageHeader/TracePageHeader.track.tsx 80% <ø> (ø)
...aeger-ui/src/utils/DraggableManager/demo/index.tsx 0% <ø> (ø)
...ges/jaeger-ui/src/components/common/VirtSelect.tsx 0% <ø> (ø)
...age/TracePageHeader/TracePageSearchBar.markers.tsx 100% <ø> (ø)
.../jaeger-ui/src/model/trace-dag/denseTransforms.tsx 70.9% <ø> (ø)
...ackages/jaeger-ui/src/components/TracePage/url.tsx 100% <ø> (ø)
...s/jaeger-ui/src/components/DependencyGraph/url.tsx 100% <ø> (ø)
.../jaeger-ui/src/components/common/NewWindowIcon.tsx 100% <ø> (ø)
...lineViewer/TimelineHeaderRow/TimelineHeaderRow.tsx 100% <ø> (ø)
... and 174 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3da2356...211cf9e. Read the comment docs.

tiffon added 2 commits March 25, 2019 11:33
@tiffon
Merge branch 'master' into ui-to-ts
e0c4496 
Signed-off-by: Joe Farro <[email protected]>
@tiffon
Remove flow
dec909f 
Signed-off-by: Joe Farro <[email protected]>
@ghost ghost assigned tiffon Mar 25, 2019
tiffon
tiffon approved these changes Mar 26, 2019
View reviewed changes
Copy link
Member

@tiffon tiffon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here we go...

@tiffon tiffon merged commit 3e5d242 into master Mar 26, 2019
@ghost ghost removed the review label Mar 26, 2019
@tiffon tiffon mentioned this pull request Mar 27, 2019
Closed
@yurishkuro yurishkuro deleted the ui-to-ts branch January 29, 2020 15:08
vvvprabhakar pushed a commit to vvvprabhakar/jaeger-ui that referenced this pull request Jul 5, 2021
@tiffon
Merge pull request jaegertracing#359 from jaegertracing/ui-to-ts
3793f0d 
Convert from Flow to Typescript for Jaeger-UI
Signed-off-by: vvvprabhakar <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tiffon tiffon tiffon approved these changes

Assignees

@tiffon tiffon

@everett980 everett980

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@everett980 @tiffon