Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[revert]: revert redux and react-redux dependency upgrades #2553

Merged
merged 3 commits into from
Jan 5, 2025

Conversation

hari45678
Copy link
Contributor

@hari45678 hari45678 commented Jan 5, 2025

Reverts #2537
Reason: #2542 (comment)
Part of #2530

Signed-off-by: Hariom Gupta <[email protected]>
Signed-off-by: Hariom Gupta <[email protected]>
@hari45678 hari45678 requested a review from a team as a code owner January 5, 2025 16:21
@hari45678 hari45678 requested review from albertteoh and removed request for a team January 5, 2025 16:21
Copy link

codecov bot commented Jan 5, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.63%. Comparing base (4a428bf) to head (8915fdd).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2553   +/-   ##
=======================================
  Coverage   96.63%   96.63%           
=======================================
  Files         255      255           
  Lines        7728     7728           
  Branches     2017     2017           
=======================================
  Hits         7468     7468           
  Misses        260      260           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Hariom Gupta <[email protected]>
@yurishkuro yurishkuro added the changelog:dependencies Update to dependencies label Jan 5, 2025
@yurishkuro yurishkuro merged commit 355758b into jaegertracing:main Jan 5, 2025
8 of 9 checks passed
@yurishkuro
Copy link
Member

Thanks. I created #2556

@hari45678 hari45678 deleted the revert-redux branch January 7, 2025 16:59
yurishkuro added a commit that referenced this pull request Jan 10, 2025
Finish incomplete change #2553 that did not fully roll back upgrades

Signed-off-by: Yuri Shkuro <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog:dependencies Update to dependencies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants