Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade @types/react to v18.x latest #1927

Merged
merged 3 commits into from
Nov 1, 2023
Merged

Conversation

anshgoyalevil
Copy link
Member

Which problem is this PR solving?

Description of the changes

  • This PR upgrades the @types/react dep to v18 latest

How was this change tested?

  • yarn lint

Checklist

@anshgoyalevil anshgoyalevil marked this pull request as ready for review November 1, 2023 06:20
@anshgoyalevil anshgoyalevil requested a review from a team as a code owner November 1, 2023 06:20
@anshgoyalevil anshgoyalevil requested review from jkowall and removed request for a team November 1, 2023 06:20
Copy link

codecov bot commented Nov 1, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Files Coverage Δ
.../src/components/common/DetailsCard/DetailTable.tsx 100.00% <100.00%> (ø)

📢 Thoughts on this report? Let us know!.

@anshgoyalevil
Copy link
Member Author

anshgoyalevil commented Nov 1, 2023

A few @dependabot PRs we can close/merge/merge with rebase safely:

@@ -27,8 +27,7 @@
},
"resolutions": {
"**/lodash": "4.17.21",
"**/@types/react": "16.14.35",
"**/@types/react-dom": "16.9.18"
"**/@types/react": "18.2.33"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need this at all here?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it forces the packages with any @type/react version requirement to stick to our version.

@yurishkuro yurishkuro added the changelog:dependencies Update to dependencies label Nov 1, 2023
@yurishkuro yurishkuro merged commit 7b5074e into jaegertracing:main Nov 1, 2023
@anshgoyalevil anshgoyalevil deleted the r1 branch November 2, 2023 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog:dependencies Update to dependencies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants