-
Notifications
You must be signed in to change notification settings - Fork 518
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade @types/react to v18.x latest #1927
Conversation
Signed-off-by: Ansh Goyal <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
📢 Thoughts on this report? Let us know!. |
A few @dependabot PRs we can close/merge/merge with rebase safely:
|
Signed-off-by: Ansh Goyal <[email protected]>
@@ -27,8 +27,7 @@ | |||
}, | |||
"resolutions": { | |||
"**/lodash": "4.17.21", | |||
"**/@types/react": "16.14.35", | |||
"**/@types/react-dom": "16.9.18" | |||
"**/@types/react": "18.2.33" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need this at all here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, it forces the packages with any @type/react
version requirement to stick to our version.
Which problem is this PR solving?
Description of the changes
@types/react
dep to v18 latestHow was this change tested?
Checklist
jaeger
:make lint test
jaeger-ui
:yarn lint
andyarn test