Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused icon #1829

Merged
merged 20 commits into from
Sep 27, 2023
Merged

Conversation

priyanshu-kun
Copy link
Contributor

@priyanshu-kun priyanshu-kun commented Sep 27, 2023

Which problem is this PR solving?

Resolves #1723

Description of the changes

  • In this PR, I refactor an unused icon which I missed in last PR.

priyanshu-kun added 20 commits September 13, 2023 20:25
…ceTimelineViewer/SpanDetail/KeyValuesTable.tsx file

Signed-off-by: priyanshu-kun <[email protected]>
Signed-off-by: priyanshu-kun <[email protected]>
Signed-off-by: priyanshu-kun <[email protected]>
Signed-off-by: priyanshu-kun <[email protected]>
@codecov
Copy link

codecov bot commented Sep 27, 2023

Codecov Report

All modified lines are covered by tests ✅

Files Coverage Δ
...lineViewer/TimelineHeaderRow/TimelineCollapser.tsx 100.00% <ø> (ø)

📢 Thoughts on this report? Let us know!.

@@ -21,3 +21,4 @@ npm-debug.log
yarn-error.log
lerna-debug.log
.eslintcache
.vscode
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I recommend you add this to your global .gitignore

@yurishkuro yurishkuro changed the title Refactor a unused icon. Remove unused icon Sep 27, 2023
@yurishkuro yurishkuro merged commit 7a98d72 into jaegertracing:main Sep 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[deps] Choose between antd/icons and react-icons
2 participants