Fixed all controversial icons. #1824
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 15 commits
September 13, 2023 20:25
…fix linting errors Signed-off-by: priyanshu-kun <[email protected]>
Signed-off-by: priyanshu-kun <[email protected]>
Signed-off-by: priyanshu-kun <[email protected]>
Signed-off-by: priyanshu-kun <[email protected]>
…ceTimelineViewer/SpanDetail/KeyValuesTable.tsx file Signed-off-by: priyanshu-kun <[email protected]>
Signed-off-by: priyanshu-kun <[email protected]>
Signed-off-by: priyanshu-kun <[email protected]>
Signed-off-by: priyanshu-kun <[email protected]>
Signed-off-by: priyanshu-kun <[email protected]>
Signed-off-by: priyanshu-kun <[email protected]>
Signed-off-by: priyanshu-kun <[email protected]>
Signed-off-by: priyanshu-kun <[email protected]>
priyanshu-kun
changed the title
Codecov ReportAll modified lines are covered by tests ✅
📢 Thoughts on this report? Let us know!. |
Signed-off-by: priyanshu-kun <[email protected]>
yurishkuro
reviewed
Sep 25, 2023
yurishkuro
reviewed
Sep 25, 2023
...eger-ui/src/components/TracePage/TraceTimelineViewer/TimelineHeaderRow/TimelineCollapser.tsx
Outdated
Show resolved
Hide resolved
yurishkuro
reviewed
Sep 25, 2023
| import { IoChevronForward } from 'react-icons/io5'; | ||
| // eslint-disable-next-line import/no-extraneous-dependencies | ||
| import { ChevronsRight, ChevronsDown } from 'lucide-react'; | ||
| import { IoChevronDown, IoChevronForward } from 'react-icons/io5'; |
There was a problem hiding this comment.
I would stick to a single family for related components - use LuChevron*
yurishkuro
reviewed
Sep 25, 2023
...eger-ui/src/components/TracePage/TraceTimelineViewer/TimelineHeaderRow/TimelineCollapser.tsx
Outdated
Show resolved
Hide resolved
|
@yurishkuro My mistake, I directly start looking for the icons outside react-icons library and I didn't check if lucide icons set present in react-icons or not. But anyway I fixed it=:) |
added 2 commits
September 26, 2023 12:57
Signed-off-by: priyanshu-kun <[email protected]>
Signed-off-by: priyanshu-kun <[email protected]>
yurishkuro
approved these changes
Sep 26, 2023
|
🥳 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Description of the changes
Checklist
jaeger:make lint testjaeger-ui:yarn lintandyarn test