Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes #167: 2 digit lookback (12h, 24h) parsing #168

Merged
merged 2 commits into from
Jan 15, 2018
Merged

fixes #167: 2 digit lookback (12h, 24h) parsing #168

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4854f14
fix 2 digit lookback (12h, 24h) parsing
golonzovsky Jan 13, 2018
5db4d6a
add double digit lookback options parsing test
golonzovsky Jan 13, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/components/SearchTracePage/TraceSearchForm.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,7 +106,7 @@ export function submitForm(fields, searchTraces) {
let start;
let end;
if (lookback !== 'custom') {
const unit = lookback[1];
const unit = lookback.substr(-1);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems like we need a unit test

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added double-digit parse test

const now = new Date();
start =
moment(now)
Expand Down