-
Notifications
You must be signed in to change notification settings - Fork 514
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove unused source-map-explorer package #1671
Conversation
Signed-off-by: Ansh Goyal <[email protected]>
what are we doing for source maps if we're not using this module? |
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #1671 +/- ##
=======================================
Coverage 96.01% 96.01%
=======================================
Files 241 241
Lines 7558 7558
Branches 1984 1984
=======================================
Hits 7257 7257
Misses 301 301 ☔ View full report in Codecov by Sentry. |
I don't think this library is being used anywhere. Where do we have source-maps inside the repository? |
but I can also see the same after applying your PR, so probably fine to merge. It's possible source maps are provided by webpack or vite directly. |
Yes. I can see a webpack config for that which uses output: {
path: join(__dirname, 'build'),
publicPath: '/',
filename: 'assets/[name].js',
}, Safe to merge, thus. |
Which problem is this PR solving?
source-map-explorer
package because:Checklist
jaeger
:make lint test
jaeger-ui
:yarn lint
andyarn test