Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused source-map-explorer package #1671

Merged
merged 2 commits into from
Aug 13, 2023

Conversation

anshgoyalevil
Copy link
Member

@anshgoyalevil anshgoyalevil commented Aug 13, 2023

Which problem is this PR solving?

  • This PR removes the source-map-explorer package because:
    • It is not being used anywhere inside the project
    • According to its npm desc., it needs to be installed globally, so anyways, not needed inside the project directly.

Checklist

Signed-off-by: Ansh Goyal <[email protected]>
@anshgoyalevil anshgoyalevil changed the title Remove source-map-explorer package Remove unused source-map-explorer package Aug 13, 2023
@yurishkuro
Copy link
Member

what are we doing for source maps if we're not using this module?

@codecov
Copy link

codecov bot commented Aug 13, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (fe0c087) 96.01% compared to head (c7d6456) 96.01%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1671   +/-   ##
=======================================
  Coverage   96.01%   96.01%           
=======================================
  Files         241      241           
  Lines        7558     7558           
  Branches     1984     1984           
=======================================
  Hits         7257     7257           
  Misses        301      301           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@anshgoyalevil
Copy link
Member Author

I don't think this library is being used anywhere. Where do we have source-maps inside the repository?

@yurishkuro
Copy link
Member

I don't know, but I am able to see some source code in the Inspector:
image

@yurishkuro
Copy link
Member

yurishkuro commented Aug 13, 2023

but I can also see the same after applying your PR, so probably fine to merge. It's possible source maps are provided by webpack or vite directly.

@yurishkuro yurishkuro enabled auto-merge (squash) August 13, 2023 19:12
@yurishkuro yurishkuro merged commit 43a1522 into jaegertracing:main Aug 13, 2023
@anshgoyalevil
Copy link
Member Author

anshgoyalevil commented Aug 13, 2023

Yes. I can see a webpack config for that which uses source-map. (It's different from source-map-explorer)

output: {
      path: join(__dirname, 'build'),
      publicPath: '/',
      filename: 'assets/[name].js',
    },

Safe to merge, thus.

@anshgoyalevil anshgoyalevil deleted the remove-sme branch August 16, 2023 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants