Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused d3-scale package #1670

Merged
merged 1 commit into from
Aug 13, 2023
Merged

Conversation

anshgoyalevil
Copy link
Member

Which problem is this PR solving?

  • This PR removes d3-scale package which is not directly used inside the project. Though it is a dep for react-vis, so no need to be installed separately.

Checklist

Signed-off-by: Ansh Goyal <[email protected]>
@codecov
Copy link

codecov bot commented Aug 13, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (82c419e) 96.01% compared to head (7673038) 96.01%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1670   +/-   ##
=======================================
  Coverage   96.01%   96.01%           
=======================================
  Files         241      241           
  Lines        7558     7558           
  Branches     1984     1984           
=======================================
  Hits         7257     7257           
  Misses        301      301           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yurishkuro yurishkuro merged commit 7333005 into jaegertracing:main Aug 13, 2023
@anshgoyalevil anshgoyalevil deleted the dep-rm branch August 16, 2023 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants