Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature] Visualize Critical Path of a trace #1582

Merged
merged 162 commits into from
Sep 4, 2023
Merged
Changes from 1 commit
Commits
Show all changes
162 commits
Select commit Hold shift + click to select a range
ee7ee31
Added new option TraceCriticalPath
GLVSKiriti Jun 30, 2023
3b4719c
Merge branch 'main' into criticalPathFeature
GLVSKiriti Jun 30, 2023
609c417
findChildSpanIds functions is added
GLVSKiriti Jun 30, 2023
5d54b8f
Critical path is now not a new view in UI
GLVSKiriti Jun 30, 2023
29dc918
ComputeCriticalPath function can find critical path
GLVSKiriti Jul 1, 2023
12107f6
License is added on top of file
GLVSKiriti Jul 1, 2023
177440b
Added a Unit Test for CriticalPath algorithm of a Normal Trace
GLVSKiriti Jul 5, 2023
a45f283
Licenses added to new files
GLVSKiriti Jul 5, 2023
a927b32
Merge branch 'main' into criticalPathFeature
GLVSKiriti Jul 6, 2023
853f160
computeCritialPath function now returns critical path sections of a …
GLVSKiriti Jul 7, 2023
068405b
Updated to suggested changes
GLVSKiriti Jul 7, 2023
facc1fa
Added unit tests and comments for helper functons
GLVSKiriti Jul 7, 2023
cc98d5d
Added a simulation diagram in comments for test1
GLVSKiriti Jul 7, 2023
5f058dd
Updated to sugested changes
GLVSKiriti Jul 7, 2023
8e5d513
Added another test case for happy path
GLVSKiriti Jul 8, 2023
74f680e
Merge branch 'main' into criticalPathFeature
GLVSKiriti Jul 8, 2023
db04fea
Used descibe.each so we can add more unit tests within short length
GLVSKiriti Jul 8, 2023
014c11d
Added sanitizeOverFlowingChildren function
GLVSKiriti Jul 8, 2023
4c55b72
Unit test added for a overflwing span case
GLVSKiriti Jul 8, 2023
011fac3
Updated to suggested changes
GLVSKiriti Jul 9, 2023
3310191
Unit tests data fixtures are refined for ease
GLVSKiriti Jul 9, 2023
bc38511
sanitizeOverFlowingChildren function is updated
GLVSKiriti Jul 9, 2023
18788d5
Unit tests are updated and modified to suggested changes
GLVSKiriti Jul 10, 2023
dc011ca
if-else block changed to switch block
GLVSKiriti Jul 10, 2023
228d6d3
Merge branch 'main' into criticalPathFeature
GLVSKiriti Jul 10, 2023
36daeb3
Modified trace diagrams and added parent child tree in comments
GLVSKiriti Jul 11, 2023
8610337
Merge branch 'main' into criticalPathFeature
GLVSKiriti Jul 12, 2023
e157ad8
Added unit tests for util functions separately
GLVSKiriti Jul 12, 2023
40f3822
Used memoization technique in critical path computation
GLVSKiriti Jul 13, 2023
b1e8960
Runned yarn prettier
GLVSKiriti Jul 13, 2023
04520d0
Critical path sections are overlaying on each span
GLVSKiriti Jul 14, 2023
1eb2f56
Runned yarn prettier
GLVSKiriti Jul 14, 2023
2f6553d
Only shows critical path if criticalPathSections is not empty
GLVSKiriti Jul 14, 2023
30f381d
Run yarn prettier
GLVSKiriti Jul 14, 2023
fb609f9
Added new option TraceCriticalPath
GLVSKiriti Jun 30, 2023
eb84a82
Bump typescript from 5.1.3 to 5.1.6 (#1530)
dependabot[bot] Jun 30, 2023
f3143a6
Bump terser from 5.18.0 to 5.18.2 (#1527)
dependabot[bot] Jun 30, 2023
e163641
Bump webpack from 5.87.0 to 5.88.1 (#1528)
dependabot[bot] Jun 30, 2023
2c75e87
Bump lerna from 7.1.0 to 7.1.1 (#1529)
dependabot[bot] Jun 30, 2023
22c6496
findChildSpanIds functions is added
GLVSKiriti Jun 30, 2023
c504765
Critical path is now not a new view in UI
GLVSKiriti Jun 30, 2023
3e5c059
ComputeCriticalPath function can find critical path
GLVSKiriti Jul 1, 2023
f8c4ba0
License is added on top of file
GLVSKiriti Jul 1, 2023
406f2cd
Added a Unit Test for CriticalPath algorithm of a Normal Trace
GLVSKiriti Jul 5, 2023
3477583
Licenses added to new files
GLVSKiriti Jul 5, 2023
38ab6a3
Release v1.31.0 (#1544)
jkowall Jul 6, 2023
107a7f2
computeCritialPath function now returns critical path sections of a …
GLVSKiriti Jul 7, 2023
1182836
Updated to suggested changes
GLVSKiriti Jul 7, 2023
1f192d0
Added unit tests and comments for helper functons
GLVSKiriti Jul 7, 2023
e9efd15
Added a simulation diagram in comments for test1
GLVSKiriti Jul 7, 2023
c1b3054
Updated to sugested changes
GLVSKiriti Jul 7, 2023
caddd53
Added another test case for happy path
GLVSKiriti Jul 8, 2023
f64fc12
Add text label to copy buttons on tags (#1547)
Yushmanth-reddy Jul 7, 2023
d680c62
Used descibe.each so we can add more unit tests within short length
GLVSKiriti Jul 8, 2023
9952d12
Added sanitizeOverFlowingChildren function
GLVSKiriti Jul 8, 2023
9859880
Unit test added for a overflwing span case
GLVSKiriti Jul 8, 2023
ce2b760
Updated to suggested changes
GLVSKiriti Jul 9, 2023
25c9516
Unit tests data fixtures are refined for ease
GLVSKiriti Jul 9, 2023
b1a536a
sanitizeOverFlowingChildren function is updated
GLVSKiriti Jul 9, 2023
e551a72
Unit tests are updated and modified to suggested changes
GLVSKiriti Jul 10, 2023
8119287
if-else block changed to switch block
GLVSKiriti Jul 10, 2023
c4a5e0f
Bump tough-cookie from 4.1.2 to 4.1.3 (#1559)
dependabot[bot] Jul 10, 2023
5be40bf
Bump vite from 4.3.9 to 4.4.2 (#1558)
dependabot[bot] Jul 10, 2023
5c11203
Add dependabot groups
yurishkuro Jul 10, 2023
48bc791
Bump the babel group with 4 updates (#1560)
dependabot[bot] Jul 10, 2023
ce85937
Add vitejs dependabot group
yurishkuro Jul 10, 2023
48d2d92
Bump the babel group with 1 update (#1563)
dependabot[bot] Jul 10, 2023
71e299d
Bump the vite group with 2 updates (#1564)
dependabot[bot] Jul 10, 2023
212a479
Bump the typescript-eslint group with 2 updates (#1561)
dependabot[bot] Jul 10, 2023
269ff7f
Bump prettier from 2.8.8 to 3.0.0 (#1553)
dependabot[bot] Jul 10, 2023
236ef62
Bump eslint from 8.43.0 to 8.44.0 (#1533)
dependabot[bot] Jul 10, 2023
3678350
Bump the vite group with 1 update (#1566)
dependabot[bot] Jul 10, 2023
1bbc183
Modified trace diagrams and added parent child tree in comments
GLVSKiriti Jul 11, 2023
245a1ec
Bump jest-environment-jsdom from 29.5.0 to 29.6.1 (#1556)
dependabot[bot] Jul 11, 2023
26e6545
Bump the typescript-eslint group with 2 updates (#1568)
dependabot[bot] Jul 11, 2023
08871a9
Bump terser from 5.18.2 to 5.19.0 (#1569)
dependabot[bot] Jul 11, 2023
0fdb1ec
Added unit tests for util functions separately
GLVSKiriti Jul 12, 2023
8457275
Used memoization technique in critical path computation
GLVSKiriti Jul 13, 2023
7daae1c
Runned yarn prettier
GLVSKiriti Jul 13, 2023
7127219
yarn prettier runned after upgrading prettier to latest
GLVSKiriti Jul 13, 2023
2f64ab1
Removed unnecessary lines
GLVSKiriti Jul 13, 2023
09e88f3
Comparator now sorts based on endTime
GLVSKiriti Jul 14, 2023
15af0a9
typo
GLVSKiriti Jul 14, 2023
a4dcc10
Revert "Removed unnecessary lines"
GLVSKiriti Jul 17, 2023
a0fbddd
Reverting to previous stage
GLVSKiriti Jul 17, 2023
7a56eb1
Reverting the changes
GLVSKiriti Jul 17, 2023
2020496
Update dev server port number in README.md (#1577)
zhuje Jul 13, 2023
5514607
Remove unused dependency react-metrics (#1578)
zhuje Jul 13, 2023
3417ee0
Bump the babel group with 4 updates (#1581)
dependabot[bot] Jul 14, 2023
b33c2ce
Bump semver from 5.7.1 to 5.7.2 (#1567)
dependabot[bot] Jul 14, 2023
906e812
Bump lerna from 7.1.1 to 7.1.3 (#1572)
dependabot[bot] Jul 14, 2023
78c9a3f
Bump the vite group with 1 update (#1579)
dependabot[bot] Jul 14, 2023
e32c693
Merge branch 'main' into criticalPathFeature
yurishkuro Jul 17, 2023
1233c42
css className is modified
GLVSKiriti Jul 18, 2023
d51c52c
Class name is changed in component
GLVSKiriti Jul 18, 2023
9abe360
Heigth value of CP line is changed
GLVSKiriti Jul 18, 2023
86800a9
Increased the z-index value
GLVSKiriti Jul 20, 2023
58266e3
transformTraceData function is refactored to take comparator as optio…
GLVSKiriti Jul 20, 2023
74a80f0
findChildSpanIds function is removed and removeFollowFromChildSpans f…
GLVSKiriti Jul 20, 2023
30724b9
Merge branch 'main' into uiBranch
GLVSKiriti Jul 26, 2023
f3feb34
Merge branch 'main' into criticalPathFeature
GLVSKiriti Jul 26, 2023
cf33dfe
Merge branch 'criticalPathFeature' into uiBranch
GLVSKiriti Jul 27, 2023
e9ed1d4
Removed unused files after merging algorithm branch changes
GLVSKiriti Jul 27, 2023
00a69b1
One more unit test is added for removeFollowFromChildSpans function
GLVSKiriti Jul 27, 2023
e8f97eb
Added unitest for sanitizeOverFlowingChildren function
GLVSKiriti Jul 27, 2023
afcb6d7
Merge branch 'criticalPathFeature' into uiBranch
GLVSKiriti Jul 27, 2023
d55d80a
Finding childSpanIds without changing the tree structure
GLVSKiriti Jul 28, 2023
dd50740
Runned yarn prettier
GLVSKiriti Jul 28, 2023
f956139
Code is updated
GLVSKiriti Jul 28, 2023
4aefb97
Merge branch 'criticalPathFeature' into uiBranch
GLVSKiriti Jul 28, 2023
5cbdf0e
Combined CP is shown on a collapsed parent span
GLVSKiriti Jul 28, 2023
fb072a1
removeFollowFromChildSpans is updated
GLVSKiriti Jul 30, 2023
7513687
updated the code
GLVSKiriti Jul 30, 2023
c5f91c3
New unit test is added but it is failing
GLVSKiriti Jul 30, 2023
464eeeb
removeFollowFromChildSpans function is updated
GLVSKiriti Jul 30, 2023
870bb51
sanitizeOverFLowingChildren function is updated
GLVSKiriti Jul 30, 2023
7c47bfb
Merge branch 'main' into criticalPathFeature
GLVSKiriti Jul 30, 2023
d2e3b12
Merge branch 'criticalPathFeature' into uiBranch
GLVSKiriti Jul 30, 2023
60a006c
Updating Typos
GLVSKiriti Aug 5, 2023
9b0dbde
Updating removeFollowsFrom function name to getChildOfSpans
GLVSKiriti Aug 5, 2023
16188a9
Modified getExpectedSanitizedData function in sanitizeOverFlowingChil…
GLVSKiriti Aug 5, 2023
05d4223
test3 file is updated
GLVSKiriti Aug 5, 2023
bc78e45
Updating a Typo
GLVSKiriti Aug 5, 2023
1be7864
Finding childSpanIds without changing TreeNode structure
GLVSKiriti Aug 5, 2023
7639755
Modified SanitizeOverflowingChildren function
GLVSKiriti Aug 8, 2023
7fb7a20
Added comments to explain findLastFinishingChild function in detail
GLVSKiriti Aug 8, 2023
a8e9df6
Merge branch 'main' into criticalPathFeature
GLVSKiriti Aug 8, 2023
40fa2ab
Mocked the criticalPath algorithm in TracePage test file
GLVSKiriti Aug 8, 2023
8d48098
Merge branch 'criticalPathFeature' into uiBranch
GLVSKiriti Aug 10, 2023
d03c4f7
Merge branch 'jaegertracing:main' into criticalPathFeature
GLVSKiriti Aug 10, 2023
7da0f35
Merge branch 'criticalPathFeature' into uiBranch
GLVSKiriti Aug 10, 2023
dd417e4
Test case added in SpanBar test file
GLVSKiriti Aug 10, 2023
d2f59c0
Modified VirtualizedTraceView test file
GLVSKiriti Aug 10, 2023
d8fdf3e
Updated License in every new file
GLVSKiriti Aug 13, 2023
8d55833
default throws a RangeError in sanitizeOverflowingChildren function
GLVSKiriti Aug 13, 2023
e8e6785
Updated code to suggested changes
GLVSKiriti Aug 13, 2023
71ac205
Updated sanitizeOverFlowingChildren function definition
GLVSKiriti Aug 13, 2023
eb28e9e
Updated sanitizeOverFlowingChildren function definition
GLVSKiriti Aug 13, 2023
290c74c
findLastFinishingChildSpanId function is update by passsing spanMap a…
GLVSKiriti Aug 13, 2023
7a51ede
computeCriticalPath also uses spanMap directly instead of traceData
GLVSKiriti Aug 13, 2023
fa6b1ee
findLastFinishingChildSpan function directly returns LFC span instead…
GLVSKiriti Aug 14, 2023
ad932aa
findRootSpanId functon id deleted as first span in trace data is alwa…
GLVSKiriti Aug 14, 2023
ac6e7cc
Code updated in index test file
GLVSKiriti Aug 14, 2023
bf479cd
sanitizeOverFlowingChildren function also now uses spanMap instead of…
GLVSKiriti Aug 15, 2023
36ce16b
Comments added for sanitizeOverflowingChildren function definition
GLVSKiriti Aug 15, 2023
82a250a
getChildOfSpans function finds the decendants of folllowsFrom spans r…
GLVSKiriti Aug 15, 2023
97d8eef
Added comments to all functions
GLVSKiriti Aug 15, 2023
2aefc3b
Merge branch 'criticalPathFeature' into uiBranch
GLVSKiriti Aug 15, 2023
0ce2049
Changed css property for critical path in spanBar css file
GLVSKiriti Aug 15, 2023
7fe65be
Modifying to suggested changes
GLVSKiriti Aug 20, 2023
8a7c424
spawnTime parameter is renamed as returningChildStartTime
GLVSKiriti Aug 20, 2023
5b767e0
Merge branch 'criticalPathFeature' into uiBranch
GLVSKiriti Aug 20, 2023
a7560d6
fixing typos
GLVSKiriti Aug 20, 2023
720c38b
Merge branch 'criticalPathFeature' into uiBranch
GLVSKiriti Aug 20, 2023
50360a3
Merge branch 'main' into uiBranch
GLVSKiriti Aug 20, 2023
46abe17
test file updated
GLVSKiriti Aug 20, 2023
f5856ee
Merge branch 'main' into uiBranch
GLVSKiriti Aug 21, 2023
f281aef
Testfile updated for criticalPath in spanBar component
GLVSKiriti Aug 21, 2023
5361025
CriticalPath feature is gated
GLVSKiriti Aug 22, 2023
6f21604
Make CP on by default
yurishkuro Sep 4, 2023
f78afde
Merge branch 'main' into uiBranch
GLVSKiriti Sep 4, 2023
c7a0151
Merge conflicts resolve
GLVSKiriti Sep 4, 2023
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Merge conflicts resolve
Signed-off-by: GLVS Kiriti <[email protected]>
  • Loading branch information
GLVSKiriti committed Sep 4, 2023
commit c7a01512d3c0097a7ea19c9b910bbd5861c30c6e
34 changes: 7 additions & 27 deletions yarn.lock
Original file line number Diff line number Diff line change
Expand Up @@ -2589,19 +2589,12 @@
resolved "https://registry.yarnpkg.com/@types/range-parser/-/range-parser-1.2.4.tgz#cd667bcfdd025213aafb7ca5915a932590acdcdc"
integrity sha512-EEhsLsD6UsDM1yFhAvy0Cjr6VwmpMWqFBCb9w07wVugF7w9nfajxLuVmngTIpgS6svCnm6Vaw+MZhoDCKnOfsw==

"@types/react-dom@18.2.5":
version "18.2.5"
resolved "https://registry.yarnpkg.com/@types/react-dom/-/react-dom-18.2.5.tgz#5c5f13548bda23cd98f50ca4a59107238bfe18f3"
integrity sha512-sRQsOS/sCLnpQhR4DSKGTtWFE3FZjpQa86KPVbhUqdYMRZ9FEFcfAytKhR/vUG2rH1oFbOOej6cuD7MFSobDRQ==
"@types/react-dom@16.9.18", "@types/react-dom@18.2.5", "@types/react-dom@^18.0.0":
version "16.9.18"
resolved "https://registry.yarnpkg.com/@types/react-dom/-/react-dom-16.9.18.tgz#1fda8b84370b1339d639a797a84c16d5a195b419"
integrity sha512-lmNARUX3+rNF/nmoAFqasG0jAA7q6MeGZK/fdeLwY3kAA4NPgHHrG5bNQe2B5xmD4B+x6Z6h0rEJQ7MEEgQxsw==
dependencies:
"@types/react" "*"

"@types/react-dom@^18.0.0":
version "18.2.7"
resolved "https://registry.yarnpkg.com/@types/react-dom/-/react-dom-18.2.7.tgz#67222a08c0a6ae0a0da33c3532348277c70abb63"
integrity sha512-GRaAEriuT4zp9N4p1i8BDBYmEyfo+xQ3yHjJU4eiK5NDa1RmUZG+unZABUTK4/Ox/M+GaHwb6Ow8rUITrtjszA==
dependencies:
"@types/react" "*"
"@types/react" "^16"

"@types/react-helmet@^6.1.5":
version "6.1.5"
Expand Down Expand Up @@ -2639,7 +2632,7 @@
dependencies:
"@types/react" "*"

"@types/react@*", "@types/[email protected]":
"@types/react@*", "@types/[email protected]", "@types/[email protected]", "@types/react@^16":
version "16.14.35"
resolved "https://registry.yarnpkg.com/@types/react/-/react-16.14.35.tgz#9d3cf047d85aca8006c4776693124a5be90ee429"
integrity sha512-NUEiwmSS1XXtmBcsm1NyRRPYjoZF2YTE89/5QiLt5mlGffYK9FQqOKuOLuXNrjPQV04oQgaZG+Yq02ZfHoFyyg==
Expand All @@ -2648,14 +2641,6 @@
"@types/scheduler" "*"
csstype "^3.0.2"

"@types/[email protected]":
version "16.8.7"
resolved "https://registry.yarnpkg.com/@types/react/-/react-16.8.7.tgz#7b1c0223dd5494f9b4501ad2a69aa6acb350a29b"
integrity sha512-0xbkIyrDNKUn4IJVf8JaCn+ucao/cq6ZB8O6kSzhrJub1cVSqgTArtG0qCfdERWKMEIvUbrwLXeQMqWEsyr9dA==
dependencies:
"@types/prop-types" "*"
csstype "^2.2.0"

"@types/[email protected]":
version "2.2.1"
resolved "https://registry.yarnpkg.com/@types/redux-actions/-/redux-actions-2.2.1.tgz#c1f4a7283ecd3cd696291550361e441bf9389370"
Expand Down Expand Up @@ -4515,11 +4500,6 @@ cssstyle@^3.0.0:
dependencies:
rrweb-cssom "^0.6.0"

csstype@^2.2.0:
version "2.6.21"
resolved "https://registry.yarnpkg.com/csstype/-/csstype-2.6.21.tgz#2efb85b7cc55c80017c66a5ad7cbd931fda3a90e"
integrity sha512-Z1PhmomIfypOpoMjRQB70jfvy/wxT50qW08YXO5lMIJkrdq4yOTR+AW7FqutScmB9NkLwxo+jU+kZLbofZZq/w==

csstype@^3.0.2:
version "3.1.2"
resolved "https://registry.yarnpkg.com/csstype/-/csstype-3.1.2.tgz#1d4bf9d572f11c14031f0436e1c10bc1f571f50b"
Expand Down Expand Up @@ -8334,7 +8314,7 @@ lodash.upperfirst@^4.3.1:
resolved "https://registry.yarnpkg.com/lodash.upperfirst/-/lodash.upperfirst-4.3.1.tgz#1365edf431480481ef0d1c68957a5ed99d49f7ce"
integrity sha512-sReKOYJIJf74dhJONhU4e0/shzi1trVbSWDOhKYE5XV2O+H7Sb2Dihwuc7xWxVl+DgFPyTqIN3zMfT9cq5iWDg==

lodash@^4.16.5, lodash@^4.17.15, lodash@^4.17.19, lodash@^4.17.20, lodash@^4.17.21, lodash@^4.17.4, lodash@^4.2.1:
lodash@4.17.21, lodash@^4.16.5, lodash@^4.17.15, lodash@^4.17.19, lodash@^4.17.20, lodash@^4.17.21, lodash@^4.17.4, lodash@^4.2.1:
version "4.17.21"
resolved "https://registry.yarnpkg.com/lodash/-/lodash-4.17.21.tgz#679591c564c3bffaae8454cf0b3df370c3d6911c"
integrity sha512-v2kDEe57lecTulaDIuNTPy3Ry4gLGJ6Z1O3vE1krgXZNrsQ+LFTGHVxVjcXPs17LhbZVGedAJv8XZ1tvj5FvSg==
Expand Down