Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore]: minimize eslint setting overrides #1565

Merged
merged 8 commits into from
Aug 18, 2023

Conversation

anikdhabal
Copy link
Contributor

Which problem is this PR solving?

Resolves #1258

Short description of the changes

made the root eslintrc also extend the recommended config from @typescript-eslint.

Signed-off-by: Anik Dhabal Babu <[email protected]>
@yurishkuro
Copy link
Member

What could be the testing methodology for this PR? I.e., just having a green CI seems insufficient as it doesn't prove that a group of files are not getting excluded from linting after the change.

@anikdhabal
Copy link
Contributor Author

What could be the testing methodology for this PR? I.e., just having a green CI seems insufficient as it doesn't prove that a group of files are not getting excluded from linting after the change.

I've tested it locally using the "eslint", but I don't think it is relevant. Any suggestion?

@yurishkuro
Copy link
Member

maybe introducing some errors in the files and observing that linting errors are reported

Signed-off-by: Anik Dhabal Babu <[email protected]>
@anikdhabal
Copy link
Contributor Author

@yurishkuro can you review it once?

.eslintrc.js Outdated Show resolved Hide resolved
Signed-off-by: Anik Dhabal Babu <[email protected]>
yurishkuro
yurishkuro previously approved these changes Aug 12, 2023
Copy link
Member

@yurishkuro yurishkuro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@yurishkuro
Copy link
Member

@anikdhabal
Copy link
Contributor Author

looks like linting is failing https://github.com/jaegertracing/jaeger-ui/actions/runs/5836530756/job/15830302191?pr=1565

Yes, trying to fix it.

Signed-off-by: Anik Dhabal Babu <[email protected]>
Signed-off-by: Anik Dhabal Babu <[email protected]>
Signed-off-by: Anik Dhabal Babu <[email protected]>
Signed-off-by: Anik Dhabal Babu <[email protected]>
@codecov
Copy link

codecov bot commented Aug 17, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.05% 🎉

Comparison is base (002932d) 95.96% compared to head (390ccfb) 96.01%.
Report is 73 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1565      +/-   ##
==========================================
+ Coverage   95.96%   96.01%   +0.05%     
==========================================
  Files         242      241       -1     
  Lines        7557     7562       +5     
  Branches     1984     1987       +3     
==========================================
+ Hits         7252     7261       +9     
+ Misses        305      301       -4     
Files Changed Coverage Δ
...mponents/TraceDiff/TraceDiffHeader/CohortTable.tsx 100.00% <ø> (ø)
...s/TracePage/TraceTimelineViewer/ListView/index.tsx 95.45% <ø> (ø)
packages/jaeger-ui/src/reducers/metrics.mock.js 100.00% <ø> (ø)
...ndencies/Graph/DdgNodeContent/calc-positioning.tsx 100.00% <100.00%> (ø)
...aeger-ui/src/components/DeepDependencies/index.tsx 100.00% <100.00%> (ø)
...r-ui/src/components/Monitor/ServicesView/index.tsx 97.34% <100.00%> (ø)
.../components/TracePage/TraceTimelineViewer/duck.tsx 98.68% <100.00%> (ø)
...jaeger-ui/src/components/TracePage/scroll-page.tsx 100.00% <100.00%> (ø)
.../src/components/common/DetailsCard/DetailTable.tsx 100.00% <100.00%> (ø)
...ages/jaeger-ui/src/components/common/TraceName.tsx 100.00% <100.00%> (ø)
... and 7 more

... and 9 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Anik Dhabal Babu <[email protected]>
@anikdhabal
Copy link
Contributor Author

@yurishkuro fixed

@yurishkuro yurishkuro merged commit fabd2e7 into jaegertracing:main Aug 18, 2023
@anshgoyalevil
Copy link
Member

286 eslint warnings were introduced with PR
https://github.com/jaegertracing/jaeger-ui/actions/runs/5907286634/job/16024953128#step:6:636
Was this the expected behavior?

@yurishkuro
Copy link
Member

286 eslint warnings were introduced with PR ... Was this the expected behavior?

Not ideal. Perhaps we can fine tune the settings, on case by case basis.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[chore]: minimize eslint setting overrides
3 participants