-
Notifications
You must be signed in to change notification settings - Fork 525
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[chore]: minimize eslint setting overrides #1565
Conversation
Signed-off-by: Anik Dhabal Babu <[email protected]>
What could be the testing methodology for this PR? I.e., just having a green CI seems insufficient as it doesn't prove that a group of files are not getting excluded from linting after the change. |
I've tested it locally using the "eslint", but I don't think it is relevant. Any suggestion? |
maybe introducing some errors in the files and observing that linting errors are reported |
Signed-off-by: Anik Dhabal Babu <[email protected]>
@yurishkuro can you review it once? |
packages/jaeger-ui/src/components/DeepDependencies/Graph/DdgNodeContent/calc-positioning.tsx
Show resolved
Hide resolved
packages/jaeger-ui/src/components/DeepDependencies/Graph/DdgNodeContent/calc-positioning.tsx
Show resolved
Hide resolved
Signed-off-by: Anik Dhabal Babu <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks!
looks like linting is failing https://github.com/jaegertracing/jaeger-ui/actions/runs/5836530756/job/15830302191?pr=1565 |
Yes, trying to fix it. |
Signed-off-by: Anik Dhabal Babu <[email protected]>
Signed-off-by: Anik Dhabal Babu <[email protected]>
Signed-off-by: Anik Dhabal Babu <[email protected]>
Signed-off-by: Anik Dhabal Babu <[email protected]>
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #1565 +/- ##
==========================================
+ Coverage 95.96% 96.01% +0.05%
==========================================
Files 242 241 -1
Lines 7557 7562 +5
Branches 1984 1987 +3
==========================================
+ Hits 7252 7261 +9
+ Misses 305 301 -4
☔ View full report in Codecov by Sentry. |
Signed-off-by: Anik Dhabal Babu <[email protected]>
@yurishkuro fixed |
286 eslint warnings were introduced with PR |
Not ideal. Perhaps we can fine tune the settings, on case by case basis. |
Which problem is this PR solving?
Resolves #1258
Short description of the changes
made the root eslintrc also extend the recommended config from @typescript-eslint.