Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Display uninstrumented service from "producer" spans #660

Closed
yurishkuro opened this issue Nov 12, 2020 · 3 comments · Fixed by #1681
Closed

Display uninstrumented service from "producer" spans #660

yurishkuro opened this issue Nov 12, 2020 · 3 comments · Fixed by #1681
Labels
enhancement good first issue help wanted

Comments

@yurishkuro
Copy link
Member

Follow-up to #659, the same logic should apply to "producer" span kinds.
@jpkrohling
Copy link
Contributor

I'm marking this as a good first issue given that we have a related issue serving as guide, but feel free to remove the label if you think it's not the case.

@ampaire
Copy link

ampaire commented May 3, 2021

Hello @jpkrohling, I would like to work on this

@jpkrohling
Copy link
Contributor

Sure, go ahead!

This was referenced Aug 14, 2023
Closed
Merged
yurishkuro added a commit that referenced this issue Aug 14, 2023
@Wck-iipi @yurishkuro
Recognize uninstrumented services via both producer and client sp…
78f94df 
…an kinds (#1681)

## Which problem is this PR solving?
Resolves #660 

## Description of the changes
VirtualizedTraceView now checks if kind is producer.

## How was this change tested?
I changed HotROD MySQL kind to producer and then tested it. 

## Checklist
- [x] I have read
https://github.com/jaegertracing/jaeger/blob/master/CONTRIBUTING_GUIDELINES.md
- [x] I have signed all commits
- [x] I have added unit tests for the new functionality
- [x] I have run lint and test steps successfully
  - for `jaeger`: `make lint test`
  - for `jaeger-ui`: `yarn lint` and `yarn test`
  

![image](https://github.com/jaegertracing/jaeger-ui/assets/110763795/a28ca271-a4f7-422c-be28-49323ab3b62e)

Signed-off-by: wck-iipi <[email protected]>
Co-authored-by: Yuri Shkuro <[email protected]>
anshgoyalevil pushed a commit to anshgoyalevil/jaeger-ui that referenced this issue Aug 16, 2023
@Wck-iipi @yurishkuro @anshgoyalevil
Recognize uninstrumented services via both producer and client sp…
f2be9a9 
…an kinds (jaegertracing#1681)

## Which problem is this PR solving?
Resolves jaegertracing#660

## Description of the changes
VirtualizedTraceView now checks if kind is producer.

## How was this change tested?
I changed HotROD MySQL kind to producer and then tested it.

## Checklist
- [x] I have read
https://github.com/jaegertracing/jaeger/blob/master/CONTRIBUTING_GUIDELINES.md
- [x] I have signed all commits
- [x] I have added unit tests for the new functionality
- [x] I have run lint and test steps successfully
  - for `jaeger`: `make lint test`
  - for `jaeger-ui`: `yarn lint` and `yarn test`

![image](https://github.com/jaegertracing/jaeger-ui/assets/110763795/a28ca271-a4f7-422c-be28-49323ab3b62e)

Signed-off-by: wck-iipi <[email protected]>
Co-authored-by: Yuri Shkuro <[email protected]>
Signed-off-by: Ansh Goyal <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement good first issue help wanted
Projects
None yet
Milestone
No milestone
3 participants
@jpkrohling @yurishkuro @ampaire