Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing css classes in AccordianReferences #534

Open
aocenas opened this issue Feb 28, 2020 · 1 comment
Open

Missing css classes in AccordianReferences #534

aocenas opened this issue Feb 28, 2020 · 1 comment
Labels

Comments

@aocenas
Copy link

aocenas commented Feb 28, 2020

Requirement - what kind of business use case are you trying to solve?

Problem - what in Jaeger blocks you from solving the requirement?

Classes for AccordianReferences are defined in the component but there is no associated css that I could find

className={cx('AccordianReferences--header', 'AccordianReferences--header', {
. Wanted to check if this is a bug and there should be some css, or the classes in component can be deleted or this is just a convention that components have classNames even if no css is actually needed.

I stumbled upon this as part of work on #509

Proposal - what do you suggest to solve the problem or improve the existing situation?

Any open questions to address

@everett980
Copy link
Collaborator

@aocenas Definitely not the convention to have unused classnames. If I had to guess, it probably resulted from the copy pasting mentioned in #498. Go ahead and remove the unused classnames.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants