Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consolidate "Accordian" Components #498

Open
everett980 opened this issue Dec 12, 2019 · 0 comments
Open

Consolidate "Accordian" Components #498

everett980 opened this issue Dec 12, 2019 · 0 comments
Labels

Comments

@everett980
Copy link
Collaborator

Problem - what in Jaeger blocks you from solving the requirement?

We have too many "Accordian" components that roughly mirror each other with a lot of copy-pasta. Here is where consolidation was proposed.

Proposal - what do you suggest to solve the problem or improve the existing situation?

We should have just one Accordion Component (without the typo) that handles all of our current use cases, including nested tables.

Any open questions to address

Because the value for a KeyValuePair is any, it should be possible to have KeyValuePair[] with string | number | AccordionProps as the value type.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants