Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add possibility to inject custom behaviour into TracePage [Subtask] #510

Closed
aocenas opened this issue Jan 13, 2020 · 1 comment
Closed

Comments

@aocenas
Copy link

aocenas commented Jan 13, 2020

Requirement - what kind of business use case are you trying to solve?

Subtask from #507

Problem - what in Jaeger blocks you from solving the requirement?

Proposal - what do you suggest to solve the problem or improve the existing situation?

For Grafana, there is a requirement to provide custom behaviour and in the future maybe even a custom elements. This encompasses things like custom navigation on clicking on span tags or showing additional context information in a modal. This can be done by injecting those to the extracted components as props or with provider pattern.

(@everett980) We have some patterns for customizable behavior (so far custom linking/annotating and optional scripts), but this will definitely require some bolstering to have optional click handlers and UI elements.
We have plans to make the config a JavaScript file instead of a JSON file, which would be a different way of defining these handlers/UI elements but would probably be consumed the same way as optional props from a parent component.

As mentioned this overlaps a bit with existing configuration though there probably isn’t need to make those 1 to 1 as I assume importing the trace components will and should allow for more fine grained control than is needed from standard Jaeger configuration.

Any open questions to address

@aocenas aocenas changed the title Add possibility to inject custom behaviour into Add possibility to inject custom behaviour into TracePage [Subtask] Jan 13, 2020
@jkowall jkowall added review and removed review labels Oct 27, 2021
@jkowall
Copy link
Contributor

jkowall commented Oct 28, 2021

Grafana decided to do their own fork to reskin, so I am closing this out.

@jkowall jkowall closed this as completed Oct 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants