Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extracting parts of TracePage into separate package. #507

Closed
aocenas opened this issue Jan 13, 2020 · 3 comments
Closed

Extracting parts of TracePage into separate package. #507

aocenas opened this issue Jan 13, 2020 · 3 comments

Comments

@aocenas
Copy link

aocenas commented Jan 13, 2020

Requirement - what kind of business use case are you trying to solve?

At Grafana we would like to integrate Jaeger UI, specifically the TraceGraph and TraceTimelineViewer components, into Grafana.

Problem - what in Jaeger blocks you from solving the requirement?

Jaeger already has the ability to provide embeddable view of the trace. For our needs that is not usable due to requirements:

  • Themeability: We want to make it as close in look and feel to rest of Grafana as possible.
  • Pluggable behaviour: Things like custom actions, additional buttons or elements.
  • Support for other backends: Allow displaying trace from any kind of backend (data transforms is not meant as part of this issue) and not depend on Jaeger server.

Proposal - what do you suggest to solve the problem or improve the existing situation?

At this moment it seems that the work can be split to 3 semi separate parts:

There are more details in this document: https://docs.google.com/document/d/1fRpiNdj3NmxDGpvkW49MlI19M5RdPa2GZloDsaz8PxU/edit?usp=sharing

As this is a bit bigger scope I would like to track the high level concerns and comments here and create separate issues for each step to be able to discuss each in more details without making the discussion confusing.

Any open questions to address

@aocenas
Copy link
Author

aocenas commented Jan 13, 2020

Hey @everett980 @rubenvp8510, hope splitting this into separate issues makes sense as this could be considered an epic rather than single task.

@everett980
Copy link
Collaborator

I agree that splitting this into separate tasks makes sense and will help with separating discussions.

Though I foresee #509 and #510 both possibly being very dependent on #508 so conversations can't be completely isolated.

@jkowall jkowall added review and removed review labels Oct 27, 2021
@jkowall
Copy link
Contributor

jkowall commented Oct 28, 2021

Grafana decided to do their own fork to reskin, so I am closing this out.

@jkowall jkowall closed this as completed Oct 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants