Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Browser back button of trace page not working if plot is clicked #323

Closed
tacigar opened this issue Feb 6, 2019 · 2 comments
Closed

Browser back button of trace page not working if plot is clicked #323

tacigar opened this issue Feb 6, 2019 · 2 comments

Comments

@tacigar
Copy link
Contributor

tacigar commented Feb 6, 2019

Requirement - what kind of business use case are you trying to solve?

If I move to the trace page by clicking Plot, the back button does not work.

jaeger-back-button

Problem - what in Jaeger blocks you from solving the requirement?

goToTrace in SearchTracePageImpl is not good.

Proposal - what do you suggest to solve the problem or improve the existing situation?

Change goToTrace from

  goToTrace = traceID => {
    const { queryOfResults } = this.props;
    this.props.history.push(getTraceLocation(traceID, { fromSearch: queryOfResults }));
  };

to

  goToTrace = traceID => {
    const { queryOfResults } = this.props;
    const searchUrl = getUrl(stripEmbeddedState(queryOfResults));
    this.props.history.push(getTraceLocation(traceID, { fromSearch: searchUrl }));
  };

Any open questions to address

@tacigar tacigar mentioned this issue Feb 6, 2019
tacigar added a commit to tacigar/jaeger-ui that referenced this issue Feb 6, 2019
Signed-off-by: Takuma Igarashi <[email protected]>
@tiffon
Copy link
Member

tiffon commented Feb 7, 2019

Thanks for creating this ticket and for the PR!

tiffon pushed a commit that referenced this issue Feb 7, 2019
Signed-off-by: Takuma Igarashi <[email protected]>
@tiffon
Copy link
Member

tiffon commented Feb 7, 2019

Fixed in #324.

@tiffon tiffon closed this as completed Feb 7, 2019
vvvprabhakar pushed a commit to vvvprabhakar/jaeger-ui that referenced this issue Jul 5, 2021
Signed-off-by: Takuma Igarashi <[email protected]>
Signed-off-by: vvvprabhakar <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants