Validate duration fields in UI #244
Assignees
Labels
Comments
everett980
added a commit
to everett980/jaeger-ui
that referenced
this issue
Dec 12, 2018
Signed-off-by: Everett Ross <[email protected]>
everett980
added a commit
to everett980/jaeger-ui
that referenced
this issue
Dec 12, 2018
Signed-off-by: Everett Ross <[email protected]>
everett980
added a commit
to everett980/jaeger-ui
that referenced
this issue
Dec 20, 2018
Signed-off-by: Everett Ross <[email protected]>
everett980
added a commit
that referenced
this issue
Jan 4, 2019
…291) * Add validation for duration fields in SearchForm (#244) Signed-off-by: Everett Ross <[email protected]> * Add tests for redux-form-field-adapter Signed-off-by: Everett Ross <[email protected]> * Fix boolean prop type Signed-off-by: Everett Ross <[email protected]> * Add boolean for input validation, change popover to show when inactive Signed-off-by: Everett Ross <[email protected]> * Add tests for onChangeAdapter Signed-off-by: Everett Ross <[email protected]> * Create separate ValidatedAdaptedInput for duration fields Signed-off-by: Everett Ross <[email protected]> * Remove unnecessary curly braces Signed-off-by: Everett Ross <[email protected]>
everett980
added a commit
to everett980/jaeger-ui
that referenced
this issue
Jan 16, 2019
…tracing#244) (jaegertracing#291) * Add validation for duration fields in SearchForm (jaegertracing#244) Signed-off-by: Everett Ross <[email protected]> * Add tests for redux-form-field-adapter Signed-off-by: Everett Ross <[email protected]> * Fix boolean prop type Signed-off-by: Everett Ross <[email protected]> * Add boolean for input validation, change popover to show when inactive Signed-off-by: Everett Ross <[email protected]> * Add tests for onChangeAdapter Signed-off-by: Everett Ross <[email protected]> * Create separate ValidatedAdaptedInput for duration fields Signed-off-by: Everett Ross <[email protected]> * Remove unnecessary curly braces Signed-off-by: Everett Ross <[email protected]> Signed-off-by: Everett Ross <[email protected]>
|
I didn't use the correct syntax in the PR that addressed this, closing now. Please re-open if the issue persists. |
vvvprabhakar
pushed a commit
to vvvprabhakar/jaeger-ui
that referenced
this issue
Jul 5, 2021
…tracing#244) (jaegertracing#291) * Add validation for duration fields in SearchForm (jaegertracing#244) Signed-off-by: Everett Ross <[email protected]> * Add tests for redux-form-field-adapter Signed-off-by: Everett Ross <[email protected]> * Fix boolean prop type Signed-off-by: Everett Ross <[email protected]> * Add boolean for input validation, change popover to show when inactive Signed-off-by: Everett Ross <[email protected]> * Add tests for onChangeAdapter Signed-off-by: Everett Ross <[email protected]> * Create separate ValidatedAdaptedInput for duration fields Signed-off-by: Everett Ross <[email protected]> * Remove unnecessary curly braces Signed-off-by: Everett Ross <[email protected]> Signed-off-by: vvvprabhakar <[email protected]>
vvvprabhakar
pushed a commit
to vvvprabhakar/jaeger-ui
that referenced
this issue
Jul 5, 2021
…tracing#244) (jaegertracing#291) * Add validation for duration fields in SearchForm (jaegertracing#244) Signed-off-by: Everett Ross <[email protected]> * Add tests for redux-form-field-adapter Signed-off-by: Everett Ross <[email protected]> * Fix boolean prop type Signed-off-by: Everett Ross <[email protected]> * Add boolean for input validation, change popover to show when inactive Signed-off-by: Everett Ross <[email protected]> * Add tests for onChangeAdapter Signed-off-by: Everett Ross <[email protected]> * Create separate ValidatedAdaptedInput for duration fields Signed-off-by: Everett Ross <[email protected]> * Remove unnecessary curly braces Signed-off-by: Everett Ross <[email protected]> Signed-off-by: Everett Ross <[email protected]> Signed-off-by: vvvprabhakar <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Requirement - what kind of business use case are you trying to solve?
Validate the duration fields before allowing the search
Problem - what in Jaeger blocks you from solving the requirement?
Currently an invalid duration field can be specified and sent to the backend, resulting in an error in the main area.
Proposal - what do you suggest to solve the problem or improve the existing situation?
Find Tracesbutton only enabled if all of the fields are valid - so when user enters content into the min/max duration fields it must be valid before the search button is re-enabled.Any open questions to address
The text was updated successfully, but these errors were encountered: