[Bug]: Popover component not closing after clicking outside the component on Compare page #1697
Labels
Comments
This was referenced Aug 18, 2023
yurishkuro
pushed a commit
that referenced
this issue
Aug 21, 2023
Signed-off-by: Riya Jain <[email protected]> ## Which problem is this PR solving? Resolves #1697 ## Description of the changes Added a z-index in TraceDiffGraph so that now when the user click outside the popup it will get closed. ## Checklist - [x] I have read https://github.com/jaegertracing/jaeger/blob/master/CONTRIBUTING_GUIDELINES.md - [x] I have signed all commits - [ ] I have added unit tests for the new functionality - [x] I have run lint and test steps successfully - for `jaeger`: `make lint test` - for `jaeger-ui`: `yarn lint` and `yarn test` Signed-off-by: Riya Jain <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
What happened?
I encountered a small but annoying bug on compare page. The popover components which are better to be closed after clicking outside the component is not closing because of this bug. It is happening because the graphs are not placed at a lower z-index than the popup component, thereby not detecting a click outside the component
Steps to reproduce
Expected behavior
The popup element should get closed
Relevant log output
No response
Screenshot
No response
Additional context
No response
Jaeger backend version
No response
SDK
No response
Pipeline
No response
Stogage backend
No response
Operating system
No response
Deployment model
No response
Deployment configs
No response
The text was updated successfully, but these errors were encountered: