Skip to content

Commit

Permalink
Added tooltip when hovered on header column of TraceStatistics view (#…
Browse files Browse the repository at this point in the history
…1902)

## Which problem is this PR solving?
- Resolves #962 

## Description of the changes
- Attach hover-over tooltips to the columns in trace statistics which
explain what each column is for

---------

Signed-off-by: GLVS Kiriti <[email protected]>
  • Loading branch information
GLVSKiriti authored Oct 22, 2023
1 parent a9e79fb commit 3df53f4
Showing 1 changed file with 12 additions and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -41,59 +41,69 @@ type State = {

const columnsArray: any[] = [
{
title: 'Name',
title: 'Group',
attribute: 'name',
suffix: '',
},
{
title: 'Count',
attribute: 'count',
suffix: '',
titleDescription: 'Number of spans',
},
{
title: 'Total',
attribute: 'total',
suffix: 'ms',
titleDescription: 'Total duration of all spans',
},
{
title: 'Avg',
attribute: 'avg',
suffix: 'ms',
titleDescription: 'Average duration of all spans',
},
{
title: 'Min',
attribute: 'min',
suffix: 'ms',
titleDescription: 'Minimum duration across all spans',
},
{
title: 'Max',
attribute: 'max',
suffix: 'ms',
titleDescription: 'Maximum duration across all spans',
},
{
title: 'ST Total',
attribute: 'selfTotal',
suffix: 'ms',
titleDescription: 'Sum of Self Time (time spent in a span when it was not waiting on children)',
},
{
title: 'ST Avg',
attribute: 'selfAvg',
suffix: 'ms',
titleDescription: 'Average Self Time (time spent in a span when it was not waiting on children)',
},
{
title: 'ST Min',
attribute: 'selfMin',
suffix: 'ms',
titleDescription: 'Minimum Self Time (time spent in a span when it was not waiting on children)',
},
{
title: 'ST Max',
attribute: 'selfMax',
suffix: 'ms',
titleDescription: 'Maximum Self Time (time spent in a span when it was not waiting on children)',
},
{
title: 'ST in Duration',
attribute: 'percent',
suffix: '%',
titleDescription: 'Percentage of ST Total vs. Total',
},
];

Expand Down Expand Up @@ -301,6 +311,7 @@ export default class TraceStatistics extends Component<Props, State> {
sorter: sorterFunction(val.attribute),
render: renderFunction,
onCell: onCellFunction,
showSorterTooltip: val.attribute !== 'name' ? { title: val.titleDescription } : false,
};
return val.attribute === 'count' ? { ...ele, defaultSortOrder: 'ascend' } : ele;
});
Expand Down

0 comments on commit 3df53f4

Please sign in to comment.