This repository has been archived by the owner on May 23, 2024. It is now read-only.
feat: extend configuration to support custom randomNumber func #555
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guanwenbogit
changed the title
Codecov Report
@@ Coverage Diff @@
## master #555 +/- ##
==========================================
+ Coverage 88.59% 88.61% +0.01%
==========================================
Files 61 61
Lines 3307 3311 +4
==========================================
+ Hits 2930 2934 +4
Misses 251 251
Partials 126 126
Continue to review full report at Codecov.
|
joe-elliott
previously requested changes
Dec 18, 2020
config/options.go
Outdated
| @@ -147,6 +148,13 @@ func Extractor(format interface{}, extractor jaeger.Extractor) Option { | |||
| } | |||
| } | |||
|
|
|||
| // WithRandonNunmber set the Tracer random number func | |||
| func WithRandonNunmber(f func() uint64) Option { | |||
There was a problem hiding this comment.
Emmmmmmmm, my mistake.
guanwenbogit
force-pushed
the
feature/with_random_number
branch
from
d1cab53 to
85164cb
Compare
yurishkuro
reviewed
Dec 21, 2020
|
Please make sure all commits are signed. Might be easier to squash them into one. See CONTRIBUTING.md. |
added 4 commits
December 21, 2020 20:14
Signed-off-by: guanwenbo <[email protected]>
Signed-off-by: guanwenbo <[email protected]>
Signed-off-by: guanwenbo <[email protected]>
Signed-off-by: guanwenbo <[email protected]>
guanwenbogit
force-pushed
the
feature/with_random_number
branch
from
821b841 to
71e806a
Compare
Signed-off-by: guanwenbo <[email protected]>
Signed-off-by: guanwenbo <[email protected]>
Signed-off-by: guanwenbo <[email protected]>
Signed-off-by: guanwenbo <[email protected]>
…enbogit/jaeger-client-go into feature/with_random_number
joe-elliott
reviewed
Dec 22, 2020
Signed-off-by: guanwenbo <[email protected]>
yurishkuro
reviewed
Dec 23, 2020
config/config_test.go
Outdated
| } | ||
| randomNum := func() uint64 { return traceID } | ||
| tracer, closer, err := cfg.NewTracer(WithRandomNumber(randomNum)) | ||
| span:=tracer.StartSpan("test-span") |
yurishkuro
reviewed
Dec 23, 2020
config/config_test.go
Outdated
| spanCtx := span.Context().(jaeger.SpanContext) | ||
|
|
||
| assert.NoError(t, err) | ||
| assert.Equal(t, spanCtx.TraceID().Low ,traceID) |
There was a problem hiding this comment.
nit: wrong argument order, expected value (traceID) goes first
Signed-off-by: guanwenbo <[email protected]>
guanwenbogit
force-pushed
the
feature/with_random_number
branch
from
6078ed8 to
379fcac
Compare
Signed-off-by: guanwenbo <[email protected]>
guanwenbogit
force-pushed
the
feature/with_random_number
branch
from
379fcac to
4e06150
Compare
yurishkuro
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Short description of the changes