[jaeger] add extraArgs and extraEnv to hotrod #463
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Default the args in the container to "all" which is the current default from the container * Allow any extra arguments to be added * Allow any environment variables to be added * Add readme entry to show how this could be done Signed-off-by: Eric Stokes <[email protected]>
fernferret
requested review from
davidvonthenen,
naseemkullah and
pavelnikolov
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
argsin the container to "all". This is the current default in the container.hotrodcontainerhotrodcontainerWhich issue this PR fixes
Checklist
[jaeger]or[jaeger-operator])