Add jaeger-ui search configuration jaegertracing/jaeger-ui#511 #348
Conversation
Signed-off-by: Gabriel Fernando Dyck <[email protected]>
GabrielDyck
changed the title
Signed-off-by: Gabriel Fernando Dyck <[email protected]>
| @@ -12,7 +12,8 @@ Several aspects of the UI can be configured: | |||
| * The Dependencies section can be enabled / configured | |||
| * Google Analytics tracking can be enabled / configured | |||
| * Additional menu options can be added to the global nav | |||
|
|
|||
| * Search input can be configured | |||
There was a problem hiding this comment.
| * Search input can be configured | |
| * Search defaults can be configured |
There was a problem hiding this comment.
In this case, it isn't a default value, it's the max value that the input(maxLimit and maxLookback) can take.
There was a problem hiding this comment.
then let's change to "search input limits", because we're not configuring "inputs"
| @@ -92,6 +100,11 @@ Links can either be members of the `menu` Array, directly, or they can be groupe | |||
|
|
|||
| The `items` Array should contain one or more link configurations. | |||
|
|
|||
| ### Search Input | |||
|
|
|||
| `search.maxLookback` allows to define the max look back interval that the ui will show in the select input. | |||
There was a problem hiding this comment.
What are the valid values for this?
There was a problem hiding this comment.
Mmm, I'm not sure about that. I'll check
There was a problem hiding this comment.
search.maxLookback configures the maximum time before the present users can query for traces.
| Field | Description |
|---|---|
| label | The text displayed in the search form dropdown |
| value | The limit used to truncate the lookbackOptions in SearchForm.js, and the value submitted in the search query if the label is selected |
Raw for above markdown:
Field | Description
------|------------
label | The text displayed in the search form dropdown
value | The limit used to truncate the `lookbackOptions` in `SearchForm.js`, and the value submitted in the search query if the label is selected
There was a problem hiding this comment.
I've just added this. Let me know for any changes.
Thanks a lot @everett980!
|
@GabrielDyck, do you need some help with moving forward with this one? |
Hello @jpkrohling . Yes, I do. I'm not sure about the valid values maxLookback can take. Do you know the valid values? |
|
@GabrielDyck looks like @everett980 added this as a comment a few hours ago: #348 (comment) Let me know if need any further help! |
GabrielDyck
force-pushed
the
master
branch
2 times, most recently
from
9f9bbf6 to
4d7b8e2
Compare
| @@ -92,6 +100,17 @@ Links can either be members of the `menu` Array, directly, or they can be groupe | |||
|
|
|||
| The `items` Array should contain one or more link configurations. | |||
|
|
|||
| ### Search Input | |||
There was a problem hiding this comment.
| ### Search Input | |
| ### Search Input Limits |
|
|
||
| The `search.maxLimit` configures the maximum results that the input let you search. | ||
|
|
||
| The `search.maxLookback` configures the maximum time before the present users can query for traces. |
There was a problem hiding this comment.
| The `search.maxLookback` configures the maximum time before the present users can query for traces. | |
| The `search.maxLookback` configures the maximum time before the present users can query for traces. The options in the Lookback dropdown greater than this value will not be shown. |
| Field | Description | ||
| ------|------------ | ||
| label | The text displayed in the search form dropdown | ||
| value | The limit used to truncate the `lookbackOptions` in `SearchForm.js`, and the value submitted in the search query if the label is selected |
There was a problem hiding this comment.
| value | The limit used to truncate the `lookbackOptions` in `SearchForm.js`, and the value submitted in the search query if the label is selected | |
| value | The value submitted in the search query if the label is selected |
Signed-off-by: Gabriel Fernando Dyck <[email protected]>
Signed-off-by: Gabriel Fernando Dyck <[email protected]>
Which problem is this PR solving?
Related to jaeger-ui PR jaegertracing/jaeger-ui#511
Short description of the changes
I've added documentation for search.maxLimit input. I've noticed that maxLookback didn't have any documentation so I added.
Let me know if it's ok
Thank you so much!
Gabriel Fernando Dyck