Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V2.0.1 #35

Merged
merged 3 commits into from
May 15, 2019
Merged

V2.0.1 #35

merged 3 commits into from
May 15, 2019

Conversation

jaebradley
Copy link
Owner

@jaebradley jaebradley commented May 15, 2019

Fix issue with contest response translator and updates documentation.

This is a backwards-incompatible change but it was done to fix a bug with contest response being a list instead of a list of lists, hence the patch upgrade instead of a major version upgrade.

This also adds a sport field to the contest draft group response translation.

@codecov
Copy link

codecov bot commented May 15, 2019

Codecov Report

Merging #35 into master will increase coverage by 0.04%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #35      +/-   ##
==========================================
+ Coverage   98.61%   98.66%   +0.04%     
==========================================
  Files          17       17              
  Lines         433      448      +15     
==========================================
+ Hits          427      442      +15     
  Misses          6        6
Impacted Files Coverage Δ
draft_kings/client.py 100% <ø> (ø) ⬆️
setup.py 0% <ø> (ø) ⬆️
tests/test_response_translators.py 100% <100%> (ø) ⬆️
draft_kings/response_translators.py 94.59% <100%> (+0.3%) ⬆️
tests/test_client.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9c4f5b2...5f4744d. Read the comment docs.

@jaebradley jaebradley merged commit e115724 into master May 15, 2019
@jaebradley jaebradley deleted the v2.0.1 branch May 15, 2019 03:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant