add slot key

[yibuyisheng]

The resolveSlots method in VUE has a if condition: https://github.com/vuejs/vue/blob/684cd7d21aa7cb9a40fb4a8542c4e08fb3801a86/src/core/instance/render-helpers/resolve-slots.js#L24

So we should add slot key for slot vnodes.

[jackmellis]

Thanks, could you add a unit test or 2 conveying the use case of this?

[yibuyisheng]

@jackmellis I made a demo here: https://jsfiddle.net/2by06fvt/1/ .

The problem is using the template slot.

In VUE's resolveSlots method, it checks template tag and use it's children as the slot: https://github.com/vuejs/vue/blob/684cd7d21aa7cb9a40fb4a8542c4e08fb3801a86/src/core/instance/render-helpers/resolve-slots.js#L29 .

[jackmellis]

Yes I think I understand what problem this is solving (many thanks btw). But I would like to have these solutions fully unit tested so there is an audit of all of the handled scenarios within the codebase.

[yibuyisheng]

OK, I'll find a time to add some unit tests.

[jackmellis]

Thanks dude

[yibuyisheng]

@jackmellis I found that the vuenit uses vue.rumtime.common.js, so in the test runtime, it dose not have a template compiler.

But I do not find out why the previous Components in test codes do not cause exceptions.

[jackmellis]

Because Vuenit also uses vue-template-compiler to compile the templates before mounting them

[yibuyisheng]

But my tests still get these errors:

[jackmellis]

Ah I think I get it.

[jackmellis]

Could you add

mount(Component)

to line 11 of the test file.

It's a little bit of a hack but it should work.

[yibuyisheng]

Could you add

mount(Component)
to line 11 of the test file.

It's a little bit of a hack but it should work.

It works.