Sync user repo / stars using RabbitMQ #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instaed of syncing user repos & stars in controller, move the logic into a consumer to be more async.
j0k3r
force-pushed
the
sync-repo-rabbit
branch
from
e33e4c5 to
9bb13f9
Compare
- Logged in user goes to `/dashboard` - Add functional test for index controller - Add some fixtures - Add twig extensions (for `|time_diff`) - Fix CSS about container height
When a repo doesn’t have tags we’ll display a custom message
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of retrieve repos & stars from a user right after the connection, use a broker to push a message to retrieve them later.
It'll avoid user to wait for the page to finish loading before being able to retrieve its feed.
In a next PR I'll add a message about sync in progress to the user. But it'll require to change a bit the homepage when a user is connected.