Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to Symfony 4.4 #267

Merged
merged 1 commit into from
May 22, 2020
Merged

Jump to Symfony 4.4 #267

merged 1 commit into from
May 22, 2020

Conversation

j0k3r
Copy link
Owner

@j0k3r j0k3r commented May 21, 2020

Migration was pretty easy, only few steps were a bit more complex.
In fact, if you've already managed all deprecated messages in the past, you won't have much code to change, mostly configuration.

Most of job can be done following different doc:

The most boring step is to move the previous config files to the new structure and split them in many small files.

Also some bundles might not be allowed to be installed for Symfony 4, which require a PR (see AshleyDawson/SimplePaginationBundle#7)

Few things that bothered me:

  • I wasn't using a mappings for Doctrine before and I spend some time understanding some issue. Found it on the symfony/demo.
  • I got a complex issue where logged in user during tests weren't working anymore. The issue were with the logout_on_user_change security parameter which went from false to true by default. During the login process, the logged in user wasn't detected as the same and got logged out. Which means I wasn't able to login at all. SO helped me I was forced to implement the isEqualTo method to check myself if the user changed (and if important stuff changed between the two).

There is massive additions mostly found in composer.lock.

Also:

  • Fixtures moved into a single file, I found more easy to understand and avoid having to remember which order between fixtures.

@coveralls
Copy link

coveralls commented May 21, 2020

Coverage Status

Coverage decreased (-0.5%) to 95.753% when pulling e02195f on feature/symfony-4 into 08f75e6 on master.

@j0k3r j0k3r force-pushed the feature/symfony-4 branch from 00c51be to e02195f Compare May 21, 2020 13:57
@j0k3r j0k3r merged commit ffa0399 into master May 22, 2020
@j0k3r j0k3r deleted the feature/symfony-4 branch May 22, 2020 05:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants