Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migration was pretty easy, only few steps were a bit more complex.
In fact, if you've already managed all deprecated messages in the past, you won't have much code to change, mostly configuration.
Most of job can be done following different doc:
The most boring step is to move the previous config files to the new structure and split them in many small files.
Also some bundles might not be allowed to be installed for Symfony 4, which require a PR (see AshleyDawson/SimplePaginationBundle#7)
Few things that bothered me:
mappings
for Doctrine before and I spend some time understanding some issue. Found it on the symfony/demo.logout_on_user_change
security parameter which went fromfalse
totrue
by default. During the login process, the logged in user wasn't detected as the same and got logged out. Which means I wasn't able to login at all. SO helped me I was forced to implement theisEqualTo
method to check myself if the user changed (and if important stuff changed between the two).There is massive additions mostly found in
composer.lock
.Also: