Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix RSS/Atom typo #154

Merged
merged 3 commits into from
Oct 3, 2019
Merged

Fix RSS/Atom typo #154

merged 3 commits into from
Oct 3, 2019

Conversation

j0k3r
Copy link
Owner

@j0k3r j0k3r commented Oct 3, 2019

Fix #153

Also:

  • update deps
  • cleanup CSS

What do you think @ad-si?

j0k3r added 2 commits October 3, 2019 09:34
@j0k3r
Fix RSS/Atom typo
fe20a8a 
Also:
- update deps
- cleanup CSS
@j0k3r
Fix tests
a58d602
@coveralls
Copy link

coveralls commented Oct 3, 2019 •
edited
Loading

Coverage Status

Coverage remained the same at 95.714% when pulling b40034a on typo into 2b668f0 on master.

ad-si
ad-si suggested changes Oct 3, 2019
View reviewed changes
Copy link

@ad-si ad-si left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Except for the 2 issues, looks good!

tests/AppBundle/Controller/DefaultControllerTest.php Outdated Show resolved Hide resolved
app/Resources/views/default/index.html.twig Outdated Show resolved Hide resolved
@j0k3r
Copy link
Owner Author

j0k3r commented Oct 3, 2019

Should be good now @ad-si

@j0k3r j0k3r merged commit 298c5da into master Oct 3, 2019
@j0k3r j0k3r deleted the typo branch October 3, 2019 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ad-si ad-si ad-si approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Don't use "RSS" to describe Atom feeds
3 participants
@j0k3r @coveralls @ad-si