-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve documentation: copy over from Parsley #48
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Till; fix minor format/spelling issues
…ire one or more successes
…tructure the docs
…f the simple numeric parsers
Fails due to a parsing error in GHC 8.10 only. gigaparsec/src/Text/Gigaparsec/Internal/Token/Lexer.hs Lines 141 to 147 in 332d364
I'm assuming it's upset at the newline before the brace, and that:
would fix this? |
…record brace in type def
j-mie6
approved these changes
Oct 28, 2024
j-mie6
approved these changes
Oct 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #39
I've copied over the docs from parsley.
I've tried to make sure to adapt it to Haskell properly.
I haven't copied over examples because my HLS was getting upset if I tried to run examples in comments.
Some modules used to re-export the entire module; I have documented using explicit exports to make it look nicer, but also re-exported the module to avoid breaking API -- this will produce warnings for duplicate exports.