Fixed shape test for test_get_program_ratings after patch to remove extraneous rows #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I just realized that there are actually 357 teams on https://kenpom.com/programs.php, even though there are 356 in the resulting DataFrame. Going to close this while I investigate further why this isn't lining up. |
|
Never mind! Not sure what happened on KenPom's side, but there are indeed 356 teams but 357 ranks; seems his list skips one...
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test broke in the last push to
master. Not sure how this slipped by my numerous tests and CI/CD, but updating to expect 356 rows in accordance with what displays on the target page.