Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement: Conference stats #50

Merged
merged 3 commits into from
Mar 20, 2023
Merged

Conversation

WakeUpWaffles
Copy link
Contributor

I have implemented pulling stats by conferences. They're pulled from this url.

It currently pulls:

  • Conference ids for a given season
  • Aggregate stats for the whole conference
  • Standing stats
  • Offense stats
  • Defense stats

Let me know if there are any changes/additions for the conferences page.
Logan

@esqew esqew requested review from esqew and j-andrews7 March 18, 2023 18:27
@esqew esqew added the enhancement New feature or request label Mar 18, 2023
@esqew
Copy link
Collaborator

esqew commented Mar 18, 2023

Thanks for the PR! I should be able to get to reviewing and providing feedback shortly.

Copy link
Collaborator

@esqew esqew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once the comments are addressed I'll give this a functional test. Thanks again for the PR!

kenpompy/conference.py Show resolved Hide resolved
kenpompy/conference.py Outdated Show resolved Hide resolved
kenpompy/conference.py Outdated Show resolved Hide resolved
Copy link
Owner

@j-andrews7 j-andrews7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree with Sean on everything. Looks good.

tests/test_conference.py Outdated Show resolved Hide resolved
@esqew esqew changed the title Feature add for stats pulled by conference Enhancement: Conference stats Mar 19, 2023
@WakeUpWaffles
Copy link
Contributor Author

Thanks for the input! I should be able to get those done by today!

WakeUpWaffles and others added 2 commits March 19, 2023 13:40
@esqew esqew merged commit 2cd0bd9 into j-andrews7:master Mar 20, 2023
@esqew
Copy link
Collaborator

esqew commented Mar 20, 2023

Thanks again for this PR. Fantastic work on this feature!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants