Skip to content

Commit

Permalink
Merge pull request #28 from esqew/bugfix/futurewarning-str-split
Browse files Browse the repository at this point in the history
Add keyword arguments for str.split (resolves #27)
  • Loading branch information
j-andrews7 authored Oct 11, 2022
2 parents 75c43fa + f35e8ea commit 36e2ab8
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions kenpompy/summary.py
Original file line number Diff line number Diff line change
Expand Up @@ -351,7 +351,7 @@ def get_playerstats(browser, season=None, metric='EFG', conf=None, conf_only=Fal

# Split ortg column.
ps_df.columns = ['Rank', 'Player', 'Team', 'ORtg', 'Ht', 'Wt', 'Yr']
ps_df[['ORtg', 'Poss%']] = ps_df['ORtg'].str.split(' ', 1, expand=True)
ps_df[['ORtg', 'Poss%']] = ps_df['ORtg'].str.split(' ', n=1, expand=True)
ps_df['Poss%'] = ps_df['Poss%'].str.strip('()')

ps_df = ps_df[ps_df.Rank != 'Rk']
Expand Down Expand Up @@ -422,7 +422,7 @@ def get_kpoy(browser, season=None):

# Some mildly moronic dataframe tidying.
kpoy_df[['Player', 'Weight', 'Year', 'Hometown']] = kpoy_df['Player'].str.split(' · ', expand=True)
kpoy_df[['Player', 'Info']] = kpoy_df['Player'].str.split(', ', 1, expand=True)
kpoy_df[['Player', 'Info']] = kpoy_df['Player'].str.split(', ', n=1, expand=True)
kpoy_df['Team'] = kpoy_df['Info'].str.replace(r'\d+', '', regex=True).str.rstrip('-')
kpoy_df['Height'] = kpoy_df['Info'].str.replace(r'[a-z]+', '', flags=re.IGNORECASE, regex=True).str.strip('. ').str.strip()
kpoy_df = kpoy_df.drop(['Info'], axis=1)
Expand All @@ -438,7 +438,7 @@ def get_kpoy(browser, season=None):

# More tidying.
mvp_df[['Player', 'Weight', 'Year', 'Hometown']] = mvp_df['Player'].str.split(' · ', expand=True)
mvp_df[['Player', 'Info']] = mvp_df['Player'].str.split(', ', 1, expand=True)
mvp_df[['Player', 'Info']] = mvp_df['Player'].str.split(', ', n=1, expand=True)
mvp_df['Team'] = mvp_df['Info'].str.replace(r'\d+', '', regex=True).str.rstrip('-')
mvp_df['Height'] = mvp_df['Info'].str.replace(r'[a-z]+', '', flags=re.IGNORECASE, regex=True).str.strip('. ').str.strip()
mvp_df = mvp_df.drop(['Info'], axis=1)
Expand Down

0 comments on commit 36e2ab8

Please sign in to comment.