Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SPM: Update min SDK & fix linker misses #333

Merged
merged 1 commit into from
Feb 17, 2021
Merged

SPM: Update min SDK & fix linker misses #333

merged 1 commit into from
Feb 17, 2021

Conversation

lickel
Copy link
Contributor

@lickel lickel commented Nov 13, 2020

This removes errors and warnings when building with Xcode 12.

@lickel
Copy link
Contributor Author

lickel commented Feb 17, 2021

bump

@paween paween merged commit 78c8e2d into iziz:master Feb 17, 2021
@lickel lickel deleted the spm branch February 17, 2021 20:02
@lickel
Copy link
Contributor Author

lickel commented Feb 17, 2021

Thanks!

@lickel
Copy link
Contributor Author

lickel commented Mar 9, 2021

@paween any chance of creating a new tag / version? Would simplify the SPM integration, e.g.

.package(name: "libPhoneNumber", url: "https://github.com/iziz/libPhoneNumber-iOS", .revision("78c8e2d17719d835c37a4b61dedcf74fee686846")),
vs
.package(name: "libPhoneNumber", url: "https://github.com/iziz/libPhoneNumber-iOS", from: "1.0.4"),

@lickel lickel mentioned this pull request May 20, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lickel @paween