Add log for negative amount in AbstractTimer.record()

See micrometer-metricsgh-2620
izeye · Jan 16, 2024 · 8650979 · 8650979
1 parent 74b5cfc
commit 8650979
Showing 1 changed file with 6 additions and 0 deletions.
diff --git a/micrometer-core/src/main/java/io/micrometer/core/instrument/AbstractTimer.java b/micrometer-core/src/main/java/io/micrometer/core/instrument/AbstractTimer.java
@@ -16,6 +16,7 @@
 package io.micrometer.core.instrument;
 
 import io.micrometer.common.lang.Nullable;
+import io.micrometer.common.util.internal.logging.WarnThenDebugLogger;
 import io.micrometer.core.instrument.distribution.*;
 import io.micrometer.core.instrument.distribution.pause.ClockDriftPauseDetector;
 import io.micrometer.core.instrument.distribution.pause.NoPauseDetector;
@@ -36,6 +37,8 @@
 
 public abstract class AbstractTimer extends AbstractMeter implements Timer {
 
+    private static final WarnThenDebugLogger log = new WarnThenDebugLogger(AbstractTimer.class);
+
     private static final Map<PauseDetector, Object> pauseDetectorCache = new ConcurrentHashMap<>();
 
     protected final Clock clock;
@@ -262,6 +265,9 @@ public final void record(long amount, TimeUnit unit) {
                 ((IntervalEstimator) intervalEstimator).recordInterval(clock.monotonicTime());
             }
         }
+        else {
+            log.log(() -> "'amount' should not be negative but was: " + amount);
+        }
     }
 
     protected abstract void recordNonNegative(long amount, TimeUnit unit);