Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix exception when etherscan responds no status #22

Open
wants to merge 36 commits into
base: master
Choose a base branch
from

Conversation

qbonnard
Copy link

@qbonnard qbonnard commented Apr 5, 2021

An exception is thrown if etherscan's json response does not include the status field, e.g. on
https://api.etherscan.io/api?module=proxy&action=eth_getTransactionByHash&txhash=0x087c822fc9b75bc4894df309cc18820f3d77659f0bc115a7035de39461a456a3

This PR first checks for the presence of the status field before checking whether it's 1

Let me know if there is a better way to do this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants