Skip to content

Commit

Permalink
github/workflows: remove golangci-lint-action step from static-analysis
Browse files Browse the repository at this point in the history
The golangci-lint-action step runs only on the repository's top-level
directory. Then, make verify reruns it on the same directory, which is
redundant.

However, to keep make verify target working, golangci-lint needs to be
installed locally.

Signed-off-by: Ivan Valdes <[email protected]>
  • Loading branch information
ivanvc committed May 6, 2024
1 parent a8c6a9c commit cdf03d6
Showing 1 changed file with 2 additions and 7 deletions.
9 changes: 2 additions & 7 deletions .github/workflows/static-analysis.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -12,13 +12,8 @@ jobs:
- uses: actions/setup-go@0c52d547c9bc32b1aa3301fd7a9cb496313a4491 # v5.0.0
with:
go-version: ${{ steps.goversion.outputs.goversion }}
- id: golangci_lint_version
run: echo "golangci_lint_version=$(cd tools/mod && go list -m -f {{.Version}} github.com/golangci/golangci-lint)" >> "$GITHUB_OUTPUT"
- name: golangci-lint
uses: golangci/golangci-lint-action@9d1e0624a798bb64f6c3cea93db47765312263dc # v5.1.0
with:
version: ${{ steps.golangci_lint_version.outputs.golangci_lint_version }}
args: --config tools/.golangci.yaml
- run: |
go install github.com/golangci/golangci-lint/cmd/golangci-lint@"$(cd tools/mod && go list -m -f {{.Version}} github.com/golangci/golangci-lint)"
- name: protoc
uses: arduino/setup-protoc@149f6c87b92550901b26acd1632e11c3662e381f # v1.3.0
with:
Expand Down

0 comments on commit cdf03d6

Please sign in to comment.