Allow appimages to run in conty #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the problem that bubblewrap doesn't normally let you run appimages due to fusermount being a SUID binary.
The fix works by passing the
--cap-add CAP_SYS_ADMINflag to bubblewrap and also by patching bubblewrap to allow nested bubblewraps with capabilities. Because otherwise Steam would not work lol.Right now the patched utils_dwarfs is being pulled from my fork of conty but I highly recommend that you get that in your own conty and also in junest and all other appimages that use bubblewrap, you can see the patch here
EDIT: Now we suck a little less than the Steam flatpak