Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

db host fix #8

Merged
merged 2 commits into from
Jan 21, 2025
Merged

db host fix #8

merged 2 commits into from
Jan 21, 2025

Conversation

alindt
Copy link
Contributor

@alindt alindt commented Jan 20, 2025

The default config for db.host is "invidious-postgresql" which only
works when the chart is installed with a release name of "invidious".

Changed the default db.host value to "${release_name}-postgresql". (could fix #3)

Also changed pullPolicy to IfNotPresent.

@unixfox unixfox requested a review from JuniorJPDJ January 20, 2025 21:01
@alindt alindt marked this pull request as draft January 20, 2025 22:01
@alindt alindt marked this pull request as ready for review January 20, 2025 22:55
@JuniorJPDJ
Copy link
Collaborator

pull policy IfNotPresent when only latest tag is available makes it unable to update on 1-node cluster

@alindt
Copy link
Contributor Author

alindt commented Jan 21, 2025

@JuniorJPDJ I think the consensus is that a particular version of a chart targets a certain version of the app and not "latest". If you want to track latest and update accordingly, there are solutions in the GitOps universe like ArgoCD, Flux, Keel etc. To summarize, switching from a pinned version to latest should be an explicit action by the user, and not the chart's default.

@JuniorJPDJ
Copy link
Collaborator

This is true, but changing pull policy to achieve that is not the best idea as you have no control over when it updates anyway.
If you want to make it not update, then pin the image digest - and do this in separate PR so we can discuss about that without blocking other changes.

The default config for db.host is "invidious-postgresql" which only
works when the chart is installed with a release name of "invidious".

Changed the default db.host value to "${release_name}-postgresql".
@alindt alindt changed the title db host fix / pullpolicy db host fix Jan 21, 2025
@alindt
Copy link
Contributor Author

alindt commented Jan 21, 2025

Ok then, I left only the db host fix.

@JuniorJPDJ
Copy link
Collaborator

Can you please also bump the chart version?

@alindt
Copy link
Contributor Author

alindt commented Jan 21, 2025

done.

@JuniorJPDJ JuniorJPDJ merged commit 28dbdb7 into iv-org:master Jan 21, 2025
@JuniorJPDJ
Copy link
Collaborator

Thank you for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: Hard-coded database name
2 participants