Update with all but two URL Parameters #360
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The documentation has been updated to include the quality_dash preference to enforce preferred quality using dash.
|
@SamantazFox Can you please review this PR, I don't know all the URL parameters. |
As far as I know, only two URL parameters are missing from here now, VR Mode and Save Player Position. I have left these off intentionally because I do not know these option well enough to know what they do, how they work, or if they would be helpful parsed through extensions like Redirector or the URL Parameters Userscript. I shall leave these two to be added by an individual more knowledgeable.
MintMain21
changed the title
TheFrenchGhosty
requested review from
SamantazFox
and removed request for
SamantazFox
SamantazFox
reviewed
Jul 14, 2023
docs/url-parameters.md
Outdated
| | _Quality_DASH_ | Default player quality when using DASH (default is Auto) | | ||
| | `quality_dash=auto` | Automatically change quality based on network conditions | | ||
| | `quality_dash=best` | Automatically use the best quality avalible | | ||
| | `quality_dash=480` | always use 480p | |
There was a problem hiding this comment.
You might add the opther qualities here (720p, 1080p, etc..)
Alternatively, you can point to the DASH quality dropdown in the preferences, or (better yet) to config option in config.example.yml.
worst is also a supported value here!
There was a problem hiding this comment.
I'm not sure if I should individually highlight every quality option, but I did at least add quality_dash=worst and clarified that any quality can be put in and it would work.
How's this?
unixfox
requested changes
Jun 26, 2024
Returned the video player parameters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The documentation has been updated to include the quality_dash preference to enforce preferred quality using dash.