Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Android: Resolve filepath for content URI #480

Merged
merged 3 commits into from
Jun 9, 2018

Conversation

andtos90
Copy link
Contributor

File sharing with the content URI will not use the original filename, I've just updated the stat API to return the original file path (the file pointed by the content uri).

Example:
screen shot 2018-04-19 at 19 09 27

@itinance
Copy link
Owner

Many thanks! Could you pls add some notes in the appropriate section of stat() in README? Thx!

@andtos90
Copy link
Contributor Author

Done, it's a brief introduction but I hope that explains the correct use case

@elribonazo
Copy link

I had a problem also with paths between the original file path and the one react-native is able to load.
How i finally solved it was adding file:// to the originalFilePath, i'm not sure of your requirements but I can work with the images perfectly now

@elribonazo
Copy link

@itinance Can we please plan the merge / pull request please?

@itinance itinance merged commit bf269a1 into itinance:master Jun 9, 2018
@rodalmeida
Copy link

@andtos90 have some concern about this, because getOriginalFilepath can actually return an empty string, if we call stat(filepath) with the original file path wouldn't it fail?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants