Skip to content

import: don't forget to set other cache config options #9423

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 16, 2023

Conversation

efiop
Copy link
Contributor

@efiop efiop commented May 8, 2023

Fixes #9385

Depends on iterative/dvc-data#351

@codecov
Copy link

codecov bot commented May 8, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.01 ⚠️

Comparison is base (be0a1a4) 91.60% compared to head (1406ffd) 91.59%.

❗ Current head 1406ffd differs from pull request most recent head f6dd423. Consider uploading reports for the commit f6dd423 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9423      +/-   ##
==========================================
- Coverage   91.60%   91.59%   -0.01%     
==========================================
  Files         489      487       -2     
  Lines       38164    37821     -343     
  Branches     5469     5440      -29     
==========================================
- Hits        34960    34644     -316     
+ Misses       2639     2620      -19     
+ Partials      565      557       -8     
Impacted Files Coverage Δ
dvc/dependency/repo.py 100.00% <100.00%> (ø)

... and 24 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@efiop efiop marked this pull request as ready for review May 16, 2023 12:53
@efiop efiop merged commit e69deaa into iterative:main May 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

dvc import ignores cache and downloads from remote
1 participant