memoize usearch.sqlite_path() #833
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattseddon
approved these changes
Jan 20, 2025
skshetry
force-pushed
the
memoize-usearch-ext
branch
from
4342707 to
187b591
Compare
Deploying datachain-documentation with
|
| Latest commit: |
d8c1a7a
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://5bba9adb.datachain-documentation.pages.dev |
| Branch Preview URL: | https://memoize-usearch-ext.datachain-documentation.pages.dev |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #833 +/- ##
==========================================
- Coverage 87.43% 87.42% -0.01%
==========================================
Files 128 128
Lines 11392 11408 +16
Branches 1552 1553 +1
==========================================
+ Hits 9961 9974 +13
- Misses 1040 1043 +3
Partials 391 391
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
skshetry
force-pushed
the
memoize-usearch-ext
branch
from
8cb8aac to
72aff4b
Compare
skshetry
force-pushed
the
memoize-usearch-ext
branch
from
72aff4b to
c28f65e
Compare
skshetry
force-pushed
the
memoize-usearch-ext
branch
from
c28f65e to
fa73f86
Compare
skshetry
force-pushed
the
memoize-usearch-ext
branch
from
fa73f86 to
a2f7dbb
Compare
skshetry
force-pushed
the
memoize-usearch-ext
branch
from
a2f7dbb to
77033ef
Compare
skshetry
force-pushed
the
memoize-usearch-ext
branch
from
77033ef to
ad78349
Compare
skshetry
force-pushed
the
memoize-usearch-ext
branch
from
ad78349 to
8323a58
Compare
skshetry
force-pushed
the
memoize-usearch-ext
branch
from
8323a58 to
9973ad7
Compare
skshetry
force-pushed
the
memoize-usearch-ext
branch
from
9973ad7 to
375f789
Compare
skshetry
force-pushed
the
memoize-usearch-ext
branch
from
375f789 to
64cfd6b
Compare
skshetry
force-pushed
the
memoize-usearch-ext
branch
from
64cfd6b to
14eb364
Compare
skshetry
force-pushed
the
memoize-usearch-ext
branch
from
14eb364 to
31ec42d
Compare
skshetry
force-pushed
the
memoize-usearch-ext
branch
from
31ec42d to
05513c3
Compare
If usearch fails to download the extension, it will keep retrying in the future. This adds significant cost - for example, in `tests/func/test_pytorch.py` run, it was invoked 111 times, taking ~30 seconds in total. Now, we cache the return value for the whole session.
skshetry
force-pushed
the
memoize-usearch-ext
branch
from
05513c3 to
d8c1a7a
Compare
|
For the record, the failing "Studio tests" are also failing in the |
dreadatour
pushed a commit
that referenced
this pull request
Jan 27, 2025
If usearch fails to download the extension, it will keep retrying in the future. This adds significant cost - for example, in `tests/func/test_pytorch.py` run, it was invoked 111 times, taking ~30 seconds in total. Now, we cache the return value for the whole session.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If
usearchfails to download the extension, it will keep retrying in the future. This adds significant cost - for example, intests/func/test_pytorch.pyrun, it was invoked 111 times, taking ~30 seconds in total.This PR caches the return value for the whole session.
Review with
?w=1for better diff. :)