Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(listing): ignore special 'dir' files #767

Merged
merged 1 commit into from
Jan 3, 2025

Conversation

shcheklein
Copy link
Member

@shcheklein shcheklein commented Jan 2, 2025

Fixes #762

We override fsspec's info to also analyze if an object listed / returned is a special case of a file like this: https://cloud.google.com/storage/docs/objects#simulated-folders

TODO:

@shcheklein shcheklein marked this pull request as draft January 2, 2025 00:05
@shcheklein shcheklein force-pushed the fix-762-special-file-listing branch from 9d137b5 to 1fdb3df Compare January 2, 2025 18:52
Copy link

cloudflare-workers-and-pages bot commented Jan 2, 2025

Deploying datachain-documentation with  Cloudflare Pages  Cloudflare Pages

Latest commit: 1fdb3df
Status: ✅  Deploy successful!
Preview URL: https://aedefdf9.datachain-documentation.pages.dev
Branch Preview URL: https://fix-762-special-file-listing.datachain-documentation.pages.dev

View logs

Copy link

codecov bot commented Jan 2, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.38%. Comparing base (508414a) to head (1fdb3df).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #767      +/-   ##
==========================================
+ Coverage   87.37%   87.38%   +0.01%     
==========================================
  Files         116      116              
  Lines       11096    11105       +9     
  Branches     1524     1525       +1     
==========================================
+ Hits         9695     9704       +9     
  Misses       1023     1023              
  Partials      378      378              
Flag Coverage Δ
datachain 87.32% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@shcheklein shcheklein self-assigned this Jan 2, 2025
@shcheklein shcheklein marked this pull request as ready for review January 2, 2025 22:37
@shcheklein shcheklein requested a review from a team January 2, 2025 22:37
@shcheklein shcheklein merged commit 59af5c3 into main Jan 3, 2025
34 checks passed
@shcheklein shcheklein deleted the fix-762-special-file-listing branch January 3, 2025 03:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Empty-named files / directories need special care
2 participants