Skip to content
This repository has been archived by the owner on Jan 5, 2021. It is now read-only.

Using operation from proposal provider should print brackets #879

Closed
tkutz opened this issue Aug 5, 2016 · 2 comments
Closed

Using operation from proposal provider should print brackets #879

tkutz opened this issue Aug 5, 2016 · 2 comments
Assignees
Milestone

Comments

@tkutz
Copy link
Contributor

tkutz commented Aug 5, 2016

When selecting an operation from proposal provider, no brackets are printed after the operation name. In case the operation has at least one parameter, we should print the brackets and put the cursor between the brackets.

@tkutz tkutz added this to the Inbox milestone Aug 5, 2016
@BeckmaR
Copy link
Contributor

BeckmaR commented Aug 8, 2016

I would say the brackets / parantheses should always be printed, although it works without them if there are no arguments - but that looks pretty confusing.

@andreasmuelder andreasmuelder modified the milestones: Inbox, S31 - TBD, Backlog Aug 8, 2016
@terfloth
Copy link
Contributor

We explicitly decided to make brackets optional for no arg ops. So creating brackets for the case operations require parameters is valid.

@andreasmuelder andreasmuelder modified the milestones: S32, Backlog Sep 12, 2016
jdicks pushed a commit that referenced this issue Sep 19, 2016
jdicks pushed a commit that referenced this issue Sep 19, 2016
jdicks pushed a commit that referenced this issue Sep 19, 2016
jdicks pushed a commit that referenced this issue Sep 19, 2016
jdicks pushed a commit that referenced this issue Sep 19, 2016
@jdicks jdicks closed this as completed Sep 21, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

5 participants