Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define exit_on_failure? to suppress thor's warning #344

Merged
merged 1 commit into from
Dec 31, 2021
Merged

Conversation

unasuke
Copy link
Member

@unasuke unasuke commented Dec 31, 2021

fix #342

see it → rails/thor#651

@@ -2,4 +2,3 @@

require 'itamae/cli'
Itamae::CLI.start

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cosmetic change 💄

@unasuke unasuke requested a review from sue445 December 31, 2021 15:05
Copy link
Member

@sue445 sue445 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@@ -36,6 +36,10 @@ def self.options
end
end

def self.exit_on_failure?
true
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also agree with this behavior

@unasuke unasuke merged commit 33d6d9a into master Dec 31, 2021
@unasuke unasuke deleted the thor_warn branch December 31, 2021 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Thor Deprecation warning
2 participants