Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add --tmp-dir to cli options #331

Merged
merged 1 commit into from
Feb 6, 2021
Merged

Add --tmp-dir to cli options #331

merged 1 commit into from
Feb 6, 2021

Conversation

sue445
Copy link
Member

@sue445 sue445 commented Feb 6, 2021

I add --tmp-dir option to cli for #330

Usage

$ itamae ssh --no-sudo -h my-server --tmp-dir /home/sue445/itamae-tmp recipe.rb

Fixes #330

@sue445 sue445 marked this pull request as ready for review February 6, 2021 16:28
@sue445 sue445 requested a review from unasuke February 6, 2021 16:45
unasuke
unasuke approved these changes Feb 6, 2021
View reviewed changes
Copy link
Member

@unasuke unasuke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@sue445
Copy link
Member Author

sue445 commented Feb 6, 2021

BTW itamae's CI is stopped for run out credit 😢

image

I requested OSS credit.
https://docs.travis-ci.com/user/billing-faq/#what-if-i-am-building-open-source

I run test suite on my local machine and all passed.

@sue445 sue445 merged commit 9dbb14e into master Feb 6, 2021
@sue445 sue445 deleted the feature/tmp-dir-arg branch February 6, 2021 17:15
@unasuke
Copy link
Member

unasuke commented Feb 6, 2021

Oh……

This was referenced Feb 6, 2021
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@unasuke unasuke unasuke approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

failed chmod when already executed itamae by other user with --no-sudo
2 participants
@sue445 @unasuke