Simplify Git resource's get_revision method #313
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request simplifies
get_revision
method ofItamae::Resource::Git
.It will improve performance.
This pull request contains two changes.
First, it replaces
git rev-list
withgit rev-parse
.git rev-parse
is faster, and enough.rev-list
prints all revisions in the specified branch, butrev-parse
only prints the head revision.It is a really simple benchmark.
Second, it reduces git command executions when
git fetch
is unnecessary.I guess this pull request only has a small impact on performance because
git
resource always try fetching new commits from the remote repository by default.